Bug 1716673

Summary: Review Request: rust-libsystemd - A pure-Rust client library to work with systemd
Product: [Fedora] Fedora Reporter: Robert Fairley <rfairley>
Component: Package ReviewAssignee: Artem <ego.cordatus>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dustymabe, ego.cordatus, igor.raits, lucab, package-review, rfairley
Target Milestone: ---Flags: ego.cordatus: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-09 19:32:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1716584    
Bug Blocks:    
Attachments:
Description Flags
Patch quickcheck crate version to 0.8 none

Description Robert Fairley 2019-06-03 21:28:52 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-libsystemd/fedora-rawhide-x86_64/00920522-rust-libsystemd/rust-libsystemd.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-libsystemd/fedora-rawhide-x86_64/00920522-rust-libsystemd/rust-libsystemd-0.1.0-1.fc31.src.rpm
Description: A pure-Rust client library to work with systemd. See more: https://crates.io/crates/libsystemd
Fedora Account System Username: rfairley

Dependency of Zincati [1] which is to be packaged in Fedora, for FCOS [2]

[1] https://github.com/coreos/zincati
[2] https://github.com/coreos/fedora-coreos-tracker/issues/190
Comment 1 Robert Fairley 2019-06-03 21:32:00 UTC 
Created attachment 1576754 [details]
Patch quickcheck crate version to 0.8

Patches the source with the change in https://github.com/lucab/libsystemd-rs/pull/13.
Comment 2 Robert Fairley 2019-06-03 21:34:08 UTC 
Note: this depends on the `try_or` crate being packaged https://bugzilla.redhat.com/show_bug.cgi?id=1716584.
Comment 3 Artem 2019-06-06 16:28:48 UTC 
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

! No license file.
! Need dot in end of description.

Otherwise OK. Package approved.
Comment 4 Igor Raits 2019-06-09 15:20:32 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libsystemd