Bug 1718338

Summary: Upcall: Avoid sending upcalls for invalid Inode
Product: [Community] GlusterFS Reporter: Soumya Koduri <skoduri>
Component: upcallAssignee: Soumya Koduri <skoduri>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, pasik, sunkumar
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1720633 1720634 (view as bug list) Environment:
Last Closed: 2020-02-10 17:29:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1717784, 1720633, 1720634, 1729221    

Description Soumya Koduri 2019-06-07 13:59:52 UTC 
Description of problem:

For nameless LOOKUPs, server creates a new inode which shall remain invalid until the fop is successfully processed post which it is linked to the inode table. 

But incase if there is an already linked inode for that entry, it discards that newly created inode which results in upcall notification. This may result in client being bombarded with unnecessary upcalls affecting performance if the data set is huge.

This issue can be avoided by looking up and storing the upcall context in the original linked inode (if exists), thus saving up on those extra callbacks.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2019-06-07 14:10:52 UTC 
REVIEW: https://review.gluster.org/22840 (upcall: Avoid sending notifications for invalid inodes) posted (#1) for review on master by soumya k
Comment 2 Sunny Kumar 2020-02-10 17:29:46 UTC 
Patch is merged upstream closing this bug.