Bug 1718338 - Upcall: Avoid sending upcalls for invalid Inode
Summary: Upcall: Avoid sending upcalls for invalid Inode
Keywords:
Status: POST
Alias: None
Product: GlusterFS
Classification: Community
Component: upcall
Version: mainline
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
Assignee: Soumya Koduri
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1717784 1720633 1720634 1729221
TreeView+ depends on / blocked
 
Reported: 2019-06-07 13:59 UTC by Soumya Koduri
Modified: 2019-07-11 15:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1720633 1720634 (view as bug list)
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Gluster.org Gerrit 22840 None Open upcall: Avoid sending notifications for invalid inodes 2019-06-07 14:10:51 UTC

Description Soumya Koduri 2019-06-07 13:59:52 UTC
Description of problem:

For nameless LOOKUPs, server creates a new inode which shall remain invalid until the fop is successfully processed post which it is linked to the inode table. 

But incase if there is an already linked inode for that entry, it discards that newly created inode which results in upcall notification. This may result in client being bombarded with unnecessary upcalls affecting performance if the data set is huge.

This issue can be avoided by looking up and storing the upcall context in the original linked inode (if exists), thus saving up on those extra callbacks.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-06-07 14:10:52 UTC
REVIEW: https://review.gluster.org/22840 (upcall: Avoid sending notifications for invalid inodes) posted (#1) for review on master by soumya k


Note You need to log in before you can comment on or make changes to this bug.