Bug 1720633

Summary: Upcall: Avoid sending upcalls for invalid Inode
Product: [Community] GlusterFS Reporter: Soumya Koduri <skoduri>
Component: upcallAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: 6CC: atumball, bugs, pasik
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1718338
: 1729221 (view as bug list) Environment:
Last Closed: 2019-07-05 09:19:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1718338, 1720634    
Bug Blocks: 1717784, 1726935, 1729221    

Description Soumya Koduri 2019-06-14 12:08:54 UTC 
+++ This bug was initially created as a clone of Bug #1718338 +++

Description of problem:

For nameless LOOKUPs, server creates a new inode which shall remain invalid until the fop is successfully processed post which it is linked to the inode table. 

But incase if there is an already linked inode for that entry, it discards that newly created inode which results in upcall notification. This may result in client being bombarded with unnecessary upcalls affecting performance if the data set is huge.

This issue can be avoided by looking up and storing the upcall context in the original linked inode (if exists), thus saving up on those extra callbacks.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2019-06-07 14:10:52 UTC ---

REVIEW: https://review.gluster.org/22840 (upcall: Avoid sending notifications for invalid inodes) posted (#1) for review on master by soumya k
Comment 1 Worker Ant 2019-06-14 12:48:34 UTC 
REVIEW: https://review.gluster.org/22873 (upcall: Avoid sending notifications for invalid inodes) posted (#1) for review on release-6 by soumya k
Comment 2 Pasi Karkkainen 2019-06-24 09:55:02 UTC 
Hmm.. it seems merge to 6.x branch is "blocked" due to a build failure regression?

https://review.gluster.org/#/c/glusterfs/+/22873/
Comment 3 Amar Tumballi 2019-07-05 08:06:20 UTC 
It got fixed now. Good to get merged soon.
Comment 4 Worker Ant 2019-07-05 09:19:24 UTC 
REVIEW: https://review.gluster.org/22873 (upcall: Avoid sending notifications for invalid inodes) merged (#6) on release-6 by hari gowtham