Bug 175279

Summary: Review Request: gift-openft: Openft plugin for giFT
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: Package ReviewAssignee: Aurelien Bompard <gauret>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-01-03 14:59:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 175276    
Bug Blocks: 163779    

Comment 1 Aurelien Bompard 2005-12-17 17:27:02 UTC
You probably mean
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-openft-0.2.1.6-1.src.rpm

Just one small problem:
"Requires: gift" is redundant, the package already depends on libgift.so.0 (you
should remove it in case you split the library out of the main package one day)

Comment 2 Rex Dieter 2005-12-19 12:48:59 UTC
%changelog
* Mon Dec 19 2005 Rex Dieter <rexdieter[AT]users.sf.net. 0.2.1.6-2
- drop redundant Requires: gift

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-openft-0.2.1.6-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-openft-0.2.1.6-2.src.rpm

Comment 3 Aurelien Bompard 2005-12-20 13:57:13 UTC
Review for release 2:
* RPM name is OK
* Source gift-openft-0.2.1.6.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of gift-openft looks OK
* File list of gift-openft looks OK
* Works
APPROVED