Spec Name or Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-0.11.8.1-1.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-0.11.8.1-1.src.rpm Description: giFT is a modular daemon capable of abstracting the communication between the end user and specific filesharing protocols (peer-to-peer or otherwise). See also previous livna review and comments: http://bugzilla.livna.org/show_bug.cgi?id=230
*** Bug 174879 has been marked as a duplicate of this bug. ***
* When building in mock, at the end of configure : use libmagic............: no -> missing BR: file * Summary should be capitalized Works fine otherwise. Peer to peer software is not listed in ForbiddenItems, so I guess giFT is OK for inclusion in Fedora, right ?
* Tue Dec 13 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.11.8.1-2 - Summary: Capitalize - BR: file (libmagic) Spec Name or Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-0.11.8.1-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-0.11.8.1-2.src.rpm
It looks like you also have to add "--enable-libmagic" for libmagic to be picked up.
%changelog * Wed Dec 14 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.11.8.1-3 - --enable-libmagic Spec Name or Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-0.11.8.1-3.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-0.11.8.1-3.src.rpm
Review for release 3: * RPM name is OK * Source gift-0.11.8.1.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint looks OK * File lists look OK * Works APPROVED