Bug 1758349

Summary: Pre-introspection 'ctlplane-ip-range' check needs to account for default values
Product: Red Hat OpenStack Reporter: Thom Carlin <tcarlin>
Component: openstack-tripleo-validationsAssignee: RHOS Maint <rhos-maint>
Status: CLOSED DUPLICATE QA Contact: nlevinki <nlevinki>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 13.0 (Queens)CC: gchamoul, jjoyce, jschluet, slinaber, tvignaud
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-04 08:15:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1715822    

Description Thom Carlin 2019-10-03 21:31:50 UTC
Description of problem:

Running 'ctlplane-ip-range' pre-introspection check against undercloud.conf with default values for ctlplane-subnet returns misleading error

Version-Release number of selected component (if applicable):

13-z

How reproducible:

100%

Steps to Reproduce:
1. Setup undercloud.conf with default ctlplane-subnet values for dhcp_start, dhcp_end
2. Run ctlplane-ip-range validation

Actual results:

[...]
TASK [Check the size of the DHCP range for overcloud nodes] ********************
fatal: [undercloud]: FAILED! => {"changed": false, "msg": "Argument start () must be an IP\nArgument end () must be an IP"}

PLAY RECAP *********************************************************************
undercloud                 : ok=4    changed=0    unreachable=0    failed=1   

Expected results:


TASK [Check the size of the DHCP range for overcloud nodes] ********************
ok: [undercloud]

PLAY RECAP *********************************************************************
undercloud                 : ok=5    changed=0    unreachable=0    failed=0   

Additional info:

Workaround:
1) edit undercloud.conf
a) for each control plane subnet (default = ctlplane-subnet) section:
i) Specify a value for dhcp_start (e.g. "dhcp_start = 192.168.24.5")
ii) Specify a value for dhcp_end (e.g. "dhcp_end = 192.168.24.29")
Rerun validation

N.B. The check is for >= 25 ip addresses in range (see https://docs.openstack.org/tripleo-validations/queens/validations-pre-introspection-details.html#ctlplane-ip-range).  This will be addressed in a separate bz