Bug 175896
| Summary: | Review Request: perl-SQL-Statement - SQL parsing and processing engine | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
| Component: | Package Review | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, tcallawa, vanmeeuwen+fedora |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/SQL-Statement/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-12 23:52:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 175895 | ||
| Bug Blocks: | |||
|
Description
Jose Pedro Oliveira
2005-12-16 00:15:50 UTC
*** Bug 177274 has been marked as a duplicate of this bug. *** Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is GPL or Artistic, matches spec. - spec file written in English and is legible - sources match upstream - package builds OK on FC4 (i386) and in mock for rawhide (i386) - BR's OK - no locales, libraries, pkgconfigs, or subpackages to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop entry needed - no scriptlets Approved. Thanks. Imported and built for FC-4 and devel. Tom, Do you want this perl module built for FC-3 ? jpo Notes: * the BR perl-DBD-XBase builds without problems in FC-3 (CVS branch needs to created) * the perl-SQL-Statement BRs DBI/DBD::File in FC-3 can be problematic if we want to improve the test suite coverage: the FC-3 DBI version doesn't include the DBD::File module (it needs to be packaged separately). More recent DBI versions include the DBD::File module but it also continues to have its own tarball in CPAN. Links: http://search.cpan.org/dist/DBI/ http://search.cpan.org/dist/DBD-File/ Its up to you. 99% of the perl modules I maintain are for perl-Maypole, and that won't build on FC-3 due to Apache restrictions. I've been building everything that works without pain on FC-3 as a convenience to other maintainers. In that case I will skip building them for FC-3. I am only packaging these modules because they are BR of perl-Log-Log4perl which I am only targeting for Fedora >= 4. *** Bug 447900 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: perl-SQL-Statement New Branches: EL-5 Updated EPEL Owners: kanarip cvs done. Setting flags properly so this doesn't show up in the review ticket queue. Note that there's no reason to open tickets just to request CVS; we only check the status of the flag. |