Bug 17712
| Summary: | XMMS hangs playing small files | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Tom Woller <twoller> |
| Component: | xmms | Assignee: | Bill Nottingham <notting> |
| Status: | CLOSED RAWHIDE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.2 | CC: | rvokal |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2000-09-19 16:48:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Fix will be added in the xmms-1.2.3-1 package. Thanks! |
when the file size is less than the calculated prebuffer size, then the oss_loop() waits for data indefinitely. modifying the code to set the prebuffer size to a limit of the file sample size fixes the problem on an ix86 platform. not much testing has occurred outside of the specific test set of .wav files (most of the .wav in the system sounds area). patch for audio.c in xmms 1.2.3 pre: --- Output/OSS/audio.c Thu Sep 14 14:57:01 2000 +++ Output/OSS/audio.c.fix Thu Sep 14 14:56:39 2000 @@ -396,6 +396,11 @@ off += cnt; } + // + // eliminate hang in oss_loop when size of file<prebuffer_size + // + if(prebuffer_size > off) + prebuffer_size = off; } else {