Bug 1777623
| Summary: | Retire ddiskit in Fedora 32+ or loose the dependency on Python 2 | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> | |
| Component: | ddiskit | Assignee: | Zamir SUN <sztsian> | |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | rawhide | CC: | ckalina, cstratak, esyr, igor.raits, lbalhar, mhroncok, ngompa13, poros, pviktori, skozina, sztsian, zbyszek, zsun | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | ddiskit-3.6-6.20191129gitde1f684.fc32 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1778138 (view as bug list) | Environment: | ||
| Last Closed: | 2019-11-29 11:24:49 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1625773, 1698500, 1708725 | |||
|
Description
Miro Hrončok
2019-11-28 01:03:42 UTC
*** Bug 1731399 has been marked as a duplicate of this bug. *** PLease don't retire this package. This does come to us as a surprise;-) We can update ddiskit for Python3, I suppose that is also an option? Should not be hard. Cestmir, do you think you could take a look at this? Thanks! > This does come to us as a surprise;-) Sorry about that. What could be improved in our communication? August: https://bugzilla.redhat.com/show_bug.cgi?id=1731399#c6 October: https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/message/2GYSDBIY7V66JAJZ6A7UHK657F4DIWPQ/ November: https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/message/NFMFRKHLPUEDXSADCNXJ2N5YHK2JG3PB/ > We can update ddiskit for Python3, I suppose that is also an option? Should not be hard. We have tried to talk to you about this in July in bz1731399. Yes, that is the preferred option. > PLease don't retire this package. We won't if you give us some reasonable deadline. If you need an "unlimited" exception, request it form FESCo please. I'm sure the communication was great, it was ignorance on our side. Looks like even Eugene confirmed that this should be trivial update (just update the interpret and do some testing). I think we can update the interpret by the end of year, is that sufficient? Hi Miro, Stanislav, If I can get the proper permission, I can make this happen no later than Dec 31st, 2019. > I think we can update the interpret by the end of year, is that sufficient?
I think it is. If I send a PR, would that help?
After some discussion with Stanislav over IRC, I'm now working on it. Personally, I'll try to make this happen within 2 weeks. Hi Miro, Now ddiskit supports Python3 in Rawhide https://src.fedoraproject.org/rpms/ddiskit/c/cdf943ff70b8514f7d2c4736681716d131b044b9?branch=master https://koji.fedoraproject.org/koji/search?terms=ddiskit-3.6-6.20191129gitde1f684.fc32&type=build&match=glob However, this bug has title aims at 'Retire', shall I close this bug as FIXED, or close this as WONTFIX? Thanks. Thanks. Verified: $ rpm -q --requires -p ddiskit-3.6-6.20191129gitde1f684.fc32.* | grep py /usr/bin/python3 python(abi) = 3.8 python3-devel python3-setuptools Renamed the bug. A quick observation about https://src.fedoraproject.org/rpms/ddiskit/c/cdf943ff70b8514f7d2c4736681716d131b044b9?branch=master It has a nested if: %if 0%{?fedora} >= 25 %if 0%{?fedora} >= 30 Note that on all RHELs/EPELs, both conditions are false. On all supported Fedoras, both conditions are true. Hence, this is an equivalent: %if 0%{?fedora} It is intended for now as I don't want to break the backwards-compatibility of the SPEC file. OTOH it worth a separate bug to track since it's not urgent (just kinda ugly). So cloned to https://bugzilla.redhat.com/show_bug.cgi?id=1778138 I'll discuss with Stanislav etc. on this. |