Bug 1778138 - ddiskit spec file have nested if which all are true now on Fedora
Summary: ddiskit spec file have nested if which all are true now on Fedora
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ddiskit
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cestmir Kalina
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-29 11:36 UTC by Zamir SUN
Modified: 2020-12-13 04:56 UTC (History)
7 users (show)

Fixed In Version: 3.6-10
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1777623
Environment:
Last Closed: 2020-12-13 04:56:46 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Zamir SUN 2019-11-29 11:36:20 UTC 
+++ This bug was initially created as a clone of Bug #1777623 +++

A quick observation about https://src.fedoraproject.org/rpms/ddiskit/c/cdf943ff70b8514f7d2c4736681716d131b044b9?branch=master


It has a nested if:

  %if 0%{?fedora} >= 25
  %if 0%{?fedora} >= 30



Note that on all RHELs/EPELs, both conditions are false. On all supported Fedoras, both conditions are true. Hence, this is an equivalent:

  %if 0%{?fedora}
Comment 1 Zamir SUN 2019-11-29 11:39:40 UTC 
I think the main point is, do we plan to have it on EPEL? If so, I'd just change part of the conditions to the corresponding el7 one.
Comment 2 Ben Cotton 2020-02-11 17:43:13 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.
Comment 3 Zamir SUN 2020-12-13 04:56:46 UTC 
Already fixed by Cestmir in 3.6-10.

Closing.
Note You need to log in before you can comment on or make changes to this bug.