Bug 1778138

Summary:	ddiskit spec file have nested if which all are true now on Fedora
Product:	[Fedora] Fedora	Reporter:	Zamir SUN <sztsian>
Component:	ddiskit	Assignee:	Cestmir Kalina <ckalina>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ckalina, esyr, mhroncok, poros, skozina, sztsian, zsun
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.6-10	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1777623	Environment:
Last Closed:	2020-12-13 04:56:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zamir SUN 2019-11-29 11:36:20 UTC

+++ This bug was initially created as a clone of Bug #1777623 +++

A quick observation about https://src.fedoraproject.org/rpms/ddiskit/c/cdf943ff70b8514f7d2c4736681716d131b044b9?branch=master


It has a nested if:

  %if 0%{?fedora} >= 25
  %if 0%{?fedora} >= 30



Note that on all RHELs/EPELs, both conditions are false. On all supported Fedoras, both conditions are true. Hence, this is an equivalent:

  %if 0%{?fedora}

Comment 1 Zamir SUN 2019-11-29 11:39:40 UTC

I think the main point is, do we plan to have it on EPEL? If so, I'd just change part of the conditions to the corresponding el7 one.

Comment 2 Ben Cotton 2020-02-11 17:43:13 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Zamir SUN 2020-12-13 04:56:46 UTC

Already fixed by Cestmir in 3.6-10.

Closing.