Bug 1785967

Summary:	Review Request: python-apply-defaults - Apply values to optional params
Product:	[Fedora] Fedora	Reporter:	Mukundan Ragavan <nonamedotc>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-04 12:49:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1785970

Description Mukundan Ragavan 2019-12-22 22:00:19 UTC

Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/apply-defaults/rnd1/python-apply-defaults.spec

SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/apply-defaults/rnd1/python-apply-defaults-0.1.4-1.fc31.src.rpm

Description:
Apply default values to functions.Makes configuration easy! Application 
settings come from a config file into your code cleanly.

Fedora Account System Username: nonamedotc


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893100

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-23 16:38:39 UTC

%{python3_sitelib}/apply_defaults → %{python3_sitelib}/apply_defaults/

%description is repeated, defining it once as a macro using %{expand:} would  be nice.

%description is incomprehensible ;( I assume this is something about rewriting
python function signatures... but the description should be more explicit.

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.

Comment 2 Mukundan Ragavan 2019-12-23 21:44:35 UTC

Thanks for the review. I will update the spec and will try and improve the description. :)

Comment 3 Gwyn Ciesla 2019-12-23 21:48:50 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-apply-defaults

Comment 4 Mukundan Ragavan 2020-01-04 12:49:14 UTC

Built on rawhide.