Bug 1785970 - Review Request: python-jsonrpcserver - Process JSON-RPC requests
Summary: Review Request: python-jsonrpcserver - Process JSON-RPC requests
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1785967 1785983 1786207
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-22 22:09 UTC by Mukundan Ragavan
Modified: 2020-01-07 23:25 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-07 23:25:09 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Mukundan Ragavan 2019-12-22 22:09:38 UTC
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/jsonrpcserver/rnd1/python-jsonrpcserver.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/jsonrpcserver/rnd1/python-jsonrpcserver-4.0.5-1.fc31.src.rpm

Description:
A Python 2.7 and 3.4+ server implementation of the JSON RPC 2.0 protocol. 
This library has been pulled out of the Python Language Server project.

Fedora Account System Username: nonamedotc

koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893125

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-23 16:27:00 UTC
%description is repeated, defining it once as a macro using %{expand:} would  be nice.

CHANGELOG.md can be added to %doc.

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
- R/P/BR look OK, but some packages are not installable:

  - nothing provides python3dist(aiozmq) needed by python3-jsonrpcserver-4.0.5-1.fc32.noarch
  - nothing provides python3.8dist(apply-defaults) < 1 needed by python3-jsonrpcserver-4.0.5-1.fc32.noarch
  - nothing provides python3dist(apply-defaults) < 1 needed by python3-jsonrpcserver-4.0.5-1.fc32.noarch

I assume apply-default will be solved by #1785967, but aiozmq seems a problem
as you said in your mail.

Comment 2 Zbigniew Jędrzejewski-Szmek 2020-01-02 08:37:44 UTC
Should be all good now. Package is APPROVED.

Comment 3 Gwyn Ciesla 2020-01-06 21:54:51 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jsonrpcserver

Comment 4 Mukundan Ragavan 2020-01-07 23:25:09 UTC
Built for rawhide.


Note You need to log in before you can comment on or make changes to this bug.