Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/apply-defaults/rnd1/python-apply-defaults.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/apply-defaults/rnd1/python-apply-defaults-0.1.4-1.fc31.src.rpm Description: Apply default values to functions.Makes configuration easy! Application settings come from a config file into your code cleanly. Fedora Account System Username: nonamedotc Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893100
%{python3_sitelib}/apply_defaults → %{python3_sitelib}/apply_defaults/ %description is repeated, defining it once as a macro using %{expand:} would be nice. %description is incomprehensible ;( I assume this is something about rewriting python function signatures... but the description should be more explicit. + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + latest version + builds and installs OK + fedora-review and rmplint seem happy + R/P/BR look OK Package is APPROVED.
Thanks for the review. I will update the spec and will try and improve the description. :)
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-apply-defaults
Built on rawhide.