Bug 1785981

Summary:	Review Request: python-socketio - Socket.IO server
Product:	[Fedora] Fedora	Reporter:	Mukundan Ragavan <nonamedotc>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-31 20:05:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1785979
Bug Blocks:	1785983

Description Mukundan Ragavan 2019-12-22 22:47:16 UTC

Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/socketio/rnd1/python-socketio.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/socketio/rnd1/python-socketio-4.4.0-1.fc31.src.rpm

Description:
Python implementation of the Socket.IO realtime client and server.

Fedora Account System Username: nonamedotc


COPR build: https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder4_rawhide/build/1134528/

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-23 15:51:56 UTC

The Summary or %description should say what this package is for, at least a little bit.
If someone (like me) doesn't know what Socket.IO is, it is hard to figure out anything
about the package right now.

%description is repeated, defining it once as a macro using %{expand:} would  be nice.

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.

Comment 2 Mukundan Ragavan 2019-12-23 21:42:14 UTC

Thanks for the review.

I will update the spec with %{expand:...} and add the following description instead of the current one.

"Socket.IO is a transport protocol that enables real-time bidirectional event-based communication between clients (typically, though not always, web browsers) and a server. The official implementations of the client and server components are written in JavaScript. This package provides Python implementations of both, each with standard and asyncio variants."

Taken, in verbatim, from docs.

Comment 3 Gwyn Ciesla 2019-12-23 21:48:24 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-socketio

Comment 4 Mukundan Ragavan 2019-12-31 20:05:29 UTC

Thanks for the review. Built on rawhide.