Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/socketio/rnd1/python-socketio.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/socketio/rnd1/python-socketio-4.4.0-1.fc31.src.rpm Description: Python implementation of the Socket.IO realtime client and server. Fedora Account System Username: nonamedotc COPR build: https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder4_rawhide/build/1134528/
The Summary or %description should say what this package is for, at least a little bit. If someone (like me) doesn't know what Socket.IO is, it is hard to figure out anything about the package right now. %description is repeated, defining it once as a macro using %{expand:} would be nice. + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + fedora-review and rmplint seem happy + R/P/BR look OK Package is APPROVED.
Thanks for the review. I will update the spec with %{expand:...} and add the following description instead of the current one. "Socket.IO is a transport protocol that enables real-time bidirectional event-based communication between clients (typically, though not always, web browsers) and a server. The official implementations of the client and server components are written in JavaScript. This package provides Python implementations of both, each with standard and asyncio variants." Taken, in verbatim, from docs.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-socketio
Thanks for the review. Built on rawhide.