Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/flask-socketio/rnd1/python-flask-socketio.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/flask-socketio/rnd1/python-flask-socketio-4.2.1-1.fc31.src.rpm Description: Flask-SocketIO --Socket.IO integration for Flask applications. Fedora Account System Username: nonamedotc COPR build: https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder4_rawhide/build/1134531/
Package name should not be repeated in %description. Expanding the %description a bit would be nice too. http://github.com/miguelgrinberg/Flask-SocketIO/ → https:// %description is repeated, defining it once as a macro using %{expand:} would be nice. %{python3_sitelib}/flask_socketio → %{python3_sitelib}/flask_socketio/ + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + fedora-review and rmplint seem happy + R/P/BR look OK Package is APPROVED.
I will add the following description so that it is clear what the package is - "Flask-SocketIO gives Flask applications access to low latency bi-directional communications between the clients and the server. The client-side application can use any of the SocketIO official clients libraries in Javascript, C++, Java and Swift, or any compatible client to establish a permanent connection to the server." Taken from the docs. Thanks for the review.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-socketio