Bug 1799463
| Summary: | OperatorHub can have duplicate items when 'all projects' is selected, which also breaks filtering | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Jon Jackson <jonjacks> | ||||||||||||||||
| Component: | OLM | Assignee: | Daniel Sover <dsover> | ||||||||||||||||
| OLM sub component: | OLM | QA Contact: | Salvatore Colangelo <scolange> | ||||||||||||||||
| Status: | CLOSED ERRATA | Docs Contact: | |||||||||||||||||
| Severity: | high | ||||||||||||||||||
| Priority: | unspecified | CC: | aos-bugs, bandrade, dsover, jiazha, jokerman, spadgett, yapei | ||||||||||||||||
| Version: | 4.4 | ||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||
| Target Release: | 4.5.0 | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Whiteboard: | |||||||||||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||
| Clone Of: | |||||||||||||||||||
| : | 1807628 1807629 1807631 1808080 (view as bug list) | Environment: | |||||||||||||||||
| Last Closed: | 2020-07-13 17:14:10 UTC | Type: | Bug | ||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||
| Embargoed: | |||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||
| Bug Blocks: | 1807628, 1807629 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
*** Bug 1797482 has been marked as a duplicate of this bug. *** It looks like OLM ignores the packagemanifest label selector when listing in all namespaces:
$ oc get packagemanifests -l '!opsrc-owner-name' -n openshift-marketplace
No resources found.
$ oc get packagemanifests -l '!opsrc-owner-name' --all-namespaces | grep openshift-marketplace | wc -l
198
This is causing console to have duplicate items returned. Here are the queries we run:
https://github.com/kyoto/console/blob/489825edc2533ec696000717ae296f730265fab5/frontend/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-page.tsx#L156-L170
I created bug 1805994 to add guards to console in case we get duplicates. Created attachment 1668170 [details]
attachement 1
Created attachment 1668171 [details]
attachement 2
Created attachment 1668172 [details]
attachement 3
Below the step for 4.4
Steps
1. Use a 4.4 cluster and ensure the following default sources are available and enabled:
- redhat-operators
- certified-operators
- community-operators
- redhat-marketplace
[scolange@scolange ~]$ oc get pod -n openshift-marketplace
NAME READY STATUS RESTARTS AGE
certified-operators-78574454c9-mnsbw 1/1 Running 1 37m
community-operators-54454f7984-sqflh 1/1 Running 1 37m
marketplace-operator-6fb54d4bb-6wvfc 1/1 Running 0 38m
redhat-marketplace-7578c8bfd6-lzmbr 1/1 Running 1 37m
redhat-operators-5ff5ddbc97-hfcf4 1/1 Running 1 37m
2. Navigate to Operators > OperatorHub
3. Select 'default' from the projects dropdown
4. Note the item count
##See attachement 1
5. Enter 'test' in the keyword filter
6. Note the filtered item count
##See attachement 2
7. Select 'all projects' from the projects dropdown
8. Enter 'test' in the keyword filter
##See attachement 3
[scolange@scolange ~]$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.4.0-0.nightly-2020-03-03-002753 True False 34m Cluster version is 4.4.0-0.nightly-2020-03-03-002753
Below the step for 4.5
Steps
1. Use a 4.5 cluster and ensure the following default sources are available and enabled:
- redhat-operators
- certified-operators
- community-operators
- redhat-marketplace
[scolange@scolange ~]$ oc get pod -n openshift-marketplace
NAME READY STATUS RESTARTS AGE
certified-operators-ccf5b4b54-shm7x 1/1 Running 0 173m
community-operators-847f8b4dc4-m4c95 1/1 Running 0 52m
marketplace-operator-7444c86bc6-6h5q8 1/1 Running 0 173m
redhat-marketplace-6554c85479-zmg7t 1/1 Running 0 173m
redhat-operators-67755cd58b-bgb8r 1/1 Running 0 173m
2. Navigate to Operators > OperatorHub
3. Select 'default' from the projects dropdown
4. Note the item count
##See attachement 4.5-1
5. Enter 'test' in the keyword filter
6. Note the filtered item count
##See attachement 4.5-2
7. Select 'all projects' from the projects dropdown
8. Enter 'test' in the keyword filter
##See attachement 4.5-3
[scolange@scolange ~]$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.5.0-0.nightly-2020-03-06-091857 True False 163m Cluster version is 4.5.0-0.nightly-2020-03-06-091857
Created attachment 1668174 [details]
4.5-1
Created attachment 1668175 [details]
4.5-2
Created attachment 1668176 [details]
4.5-3
*** Bug 1807629 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |
Created attachment 1659194 [details] Demonstration of bug Description of problem: Selecting 'all-projects' on the OperatorHub page causes the operator items on the page to be duplicated and breaks the filtering functionality. Version-Release number of selected component (if applicable): 4.4 How reproducible: Always under the correct conditions Steps to Reproduce: 1. Use a 4.4 cluster and ensure the following default sources are available and enabled: - redhat-operators - certified-operators - community-operators - redhat-marketplace 2. Navigate to Operators > OperatorHub 3. Select 'default' from the projects dropdown 4. Note the item count 5. Enter 'test' in the keyword filter 6. Note the filtered item count 7. Select 'all projects' from the projects dropdown 8. Enter 'test' in the keyword filter Actual results: Item count is doubled both before and after the filter term is entered and duplicate items are being displayed on the page. Item count also does not match the number of items displayed on the page. Expected results: Duplicate items should not be displayed and item count should match the number of items displayed. Additional info: Suspect that packageManifest and marketPlacePackageManifest props retreived by firehose component contain overlapping results depending on what catalog sources are available and what namespace is selected. Probably need to either add a special case when all projects is selected, adjust our selectors to ensure no overlap, or add some logic after the call to reduce the package manifest props to a single unique list.