Bug 1803310

Summary: Review Request: golang-github-vilmibm-termd - Package termd provides terminal markdown rendering, with code block syntax highlighting support
Product: [Fedora] Fedora Reporter: Joe Doss <joe>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 15:48:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1803302    

Comment 1 Robert-André Mauchin 🐧 2020-02-16 22:23:06 UTC
 - Why did you not package 0.2.0?

Version:                0.2.0
%global tag             v0.2.0


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Tests are ok
 - Conforms to Packaging Guidelines

Package approved. Please package the latest version.

Comment 2 Joe Doss 2020-02-20 21:06:55 UTC
I packaged the older version because they didn't tag 0.2.0 correctly and I didn't know about using %global tag.

$ spectool -R -g SPECS/golang-github-vilmibm-termd.spec
Getting https://github.com/vilmibm/go-termd/archive/v0.2.0/go-termd-0.2.0.tar.gz to /home/jdoss/rpmbuild/SOURCES/go-termd-0.2.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   139    0   139    0     0    482      0 --:--:-- --:--:-- --:--:--   482
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

using:

Version:                0.2.0
%global tag             0.2.0

works:

$ spectool -R -g SPECS/golang-github-vilmibm-termd.spec 
Getting https://github.com/vilmibm/go-termd/archive/0.2.0/go-termd-0.2.0.tar.gz to /home/jdoss/rpmbuild/SOURCES/go-termd-0.2.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   123    0   123    0     0    480      0 --:--:-- --:--:-- --:--:--   480
100  9102    0  9102    0     0  18575      0 --:--:-- --:--:-- --:--:-- 18575


- Packaged latest version.

https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246641-golang-github-vilmibm-termd/golang-github-vilmibm-termd.spec
https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246641-golang-github-vilmibm-termd/golang-github-vilmibm-termd-0.2.0-1.fc31.src.rpm

Comment 3 Joe Doss 2020-10-27 15:48:30 UTC
I am not moving forward on this package since it is not needed anymore for the GitHub CLI package.