Bug 1803310 - Review Request: golang-github-vilmibm-termd - Package termd provides terminal markdown rendering, with code block syntax highlighting support
Summary: Review Request: golang-github-vilmibm-termd - Package termd provides terminal...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1803302
TreeView+ depends on / blocked
 
Reported: 2020-02-15 05:38 UTC by Joe Doss
Modified: 2020-10-27 15:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 15:48:30 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Joe Doss 2020-02-15 05:38:56 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01240097-golang-github-vilmibm-termd/golang-github-vilmibm-termd.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01240097-golang-github-vilmibm-termd/golang-github-vilmibm-termd-0.0.4-1.fc31.src.rpm
Description: Package termd provides terminal markdown rendering, with code block syntax highlighting support
Fedora Account System Username: jdoss
Comment 1 Robert-André Mauchin 🐧 2020-02-16 22:23:06 UTC 
 - Why did you not package 0.2.0?

Version:                0.2.0
%global tag             v0.2.0


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Tests are ok
 - Conforms to Packaging Guidelines

Package approved. Please package the latest version.
Comment 2 Joe Doss 2020-02-20 21:06:55 UTC 
I packaged the older version because they didn't tag 0.2.0 correctly and I didn't know about using %global tag.

$ spectool -R -g SPECS/golang-github-vilmibm-termd.spec
Getting https://github.com/vilmibm/go-termd/archive/v0.2.0/go-termd-0.2.0.tar.gz to /home/jdoss/rpmbuild/SOURCES/go-termd-0.2.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   139    0   139    0     0    482      0 --:--:-- --:--:-- --:--:--   482
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

using:

Version:                0.2.0
%global tag             0.2.0

works:

$ spectool -R -g SPECS/golang-github-vilmibm-termd.spec 
Getting https://github.com/vilmibm/go-termd/archive/0.2.0/go-termd-0.2.0.tar.gz to /home/jdoss/rpmbuild/SOURCES/go-termd-0.2.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   123    0   123    0     0    480      0 --:--:-- --:--:-- --:--:--   480
100  9102    0  9102    0     0  18575      0 --:--:-- --:--:-- --:--:-- 18575


- Packaged latest version.

https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246641-golang-github-vilmibm-termd/golang-github-vilmibm-termd.spec
https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246641-golang-github-vilmibm-termd/golang-github-vilmibm-termd-0.2.0-1.fc31.src.rpm
Comment 3 Joe Doss 2020-10-27 15:48:30 UTC 
I am not moving forward on this package since it is not needed anymore for the GitHub CLI package.
Note You need to log in before you can comment on or make changes to this bug.