Bug 1803312
| Summary: | Review Request: golang-github-hinshun-vt10x - Package vt10x is a vt10x terminal emulation backend | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joe Doss <joe> |
| Component: | Package Review | Assignee: | Jared Smith <jsmith.fedora> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, jsmith.fedora, package-review, ppisar |
| Target Milestone: | --- | Flags: | jsmith.fedora:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-06 14:18:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1803302 | ||
|
Description
Joe Doss
2020-02-15 05:44:26 UTC
- Remove extra dot in description: .} - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Tests are ok - Conforms to Packaging Guidelines Package approved. - Removed extra dot in description. https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246623-golang-github-hinshun-vt10x/golang-github-hinshun-vt10x.spec https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246623-golang-github-hinshun-vt10x/golang-github-hinshun-vt10x-0-0.1.20200214gitd55458d.fc31.src.rpm Joe, Are you going to continue with the process of getting this package into Fedora? Hey Jared, Yes, but if you want to take this over to help push it forward, I could use the help. I am stretched pretty thin right now with everything that is going on in the world. It looks like Jared didn't take this over. I am ready to move it forward with new builds that need to be reviewed: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708534-golang-github-hinshun-vt10x/golang-github-hinshun-vt10x.spec https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708534-golang-github-hinshun-vt10x/golang-github-hinshun-vt10x-0-0.1.20201001gitd55458d.fc33.src.rpm If you need a new review, then open a new request. Otherwise add the approved version into Fedora and upgrade it to your version. Hey Petr, $ fedpkg request-repo golang-github-netflix-expect 1803309 Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago Should I open new request or can you re-approve it? That command output should have been this one: fedpkg request-repo golang-github-hinshun-vt10x 1803312 Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago I see. I forgot there is a limit for the review age. Either open a new request, or reset this one the original state (NEW state, default assignee, unset fedora-review flag). Whatever suits you better. I cannot understand Go, thus I'm not going to re-approve this review. I'm happy to re-review this package. Package is re-approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hinshun-vt10x |