Bug 1803312 - Review Request: golang-github-hinshun-vt10x - Package vt10x is a vt10x terminal emulation backend
Summary: Review Request: golang-github-hinshun-vt10x - Package vt10x is a vt10x termin...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jared Smith
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1803302
TreeView+ depends on / blocked
 
Reported: 2020-02-15 05:44 UTC by Joe Doss
Modified: 2020-11-06 14:18 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-11-06 14:18:03 UTC
Type: ---
Embargoed:
jsmith.fedora: fedora-review+


Attachments (Terms of Use)

Description Joe Doss 2020-02-15 05:44:26 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jdoss/github/fedora-31-x86_64/01240575-golang-github-hinshun-vt10x/golang-github-hinshun-vt10x.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jdoss/github/fedora-31-x86_64/01240575-golang-github-hinshun-vt10x/golang-github-hinshun-vt10x-0-0.1.20200214gitd55458d.fc31.src.rpm
Description: Package vt10x is a vt10x terminal emulation backend, influenced largely by st, rxvt, xterm, and iTerm as reference. Use it for terminal muxing, a terminal emulation frontend, or wherever else you need terminal emulation.
Fedora Account System Username: jdoss

Comment 1 Robert-André Mauchin 🐧 2020-02-16 22:50:10 UTC
 - Remove extra dot in description:

.}

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Tests are ok
 - Conforms to Packaging Guidelines

Package approved.

Comment 3 Jared Smith 2020-04-14 16:32:45 UTC
Joe,

Are you going to continue with the process of getting this package into Fedora?

Comment 4 Joe Doss 2020-04-14 16:47:37 UTC
Hey Jared,

Yes, but if you want to take this over to help push it forward, I could use the help. I am stretched pretty thin right now with everything that is going on in the world.

Comment 6 Petr Pisar 2020-10-23 11:58:21 UTC
If you need a new review, then open a new request. Otherwise add the approved version into Fedora and upgrade it to your version.

Comment 7 Joe Doss 2020-10-27 15:37:20 UTC
Hey Petr,

$ fedpkg request-repo golang-github-netflix-expect 1803309                   
Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago


Should I open new request or can you re-approve it?

Comment 8 Joe Doss 2020-10-27 15:39:27 UTC
That command output should have been this one:

fedpkg request-repo golang-github-hinshun-vt10x 1803312 
Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago

Comment 9 Petr Pisar 2020-10-29 07:35:33 UTC
I see. I forgot there is a limit for the review age. Either open a new request, or reset this one the original state (NEW state, default assignee, unset fedora-review flag). Whatever suits you better.

I cannot understand Go, thus I'm not going to re-approve this review.

Comment 10 Jared Smith 2020-10-30 19:35:49 UTC
I'm happy to re-review this package.

Comment 11 Jared Smith 2020-10-30 19:36:29 UTC
Package is re-approved.

Comment 12 Gwyn Ciesla 2020-11-03 15:45:59 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hinshun-vt10x


Note You need to log in before you can comment on or make changes to this bug.