Bug 1805994

Summary: OperatorHub can have duplicate items when 'all projects' is selected, which also breaks filtering
Product: OpenShift Container Platform Reporter: Samuel Padgett <spadgett>
Component: Management ConsoleAssignee: Joe Caiani <jcaiani>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.4CC: aos-bugs, jokerman, tony.wu, xiaocwan
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1806155 (view as bug list) Environment:
Last Closed: 2020-08-04 18:01:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1806155    
Attachments:
Description Flags
tolerate duplicated operators in operatorhub none

Description Samuel Padgett 2020-02-21 19:48:33 UTC 
This bug was initially created as a copy of Bug #1799463

I am copying this bug because: 

We should tolerate duplicates in console even if they're not expected.

Description of problem:

Selecting 'all-projects' on the OperatorHub page causes the operator items on the page to be duplicated and breaks the filtering functionality.

Version-Release number of selected component (if applicable):
4.4

How reproducible:
Always under the correct conditions

Steps to Reproduce:
1. Use a 4.4 cluster and ensure the following default sources are available and enabled:
   - redhat-operators
   - certified-operators
   - community-operators
   - redhat-marketplace 
2. Navigate to Operators > OperatorHub
3. Select 'default' from the projects dropdown
4. Note the item count
5. Enter 'test' in the keyword filter
6. Note the filtered item count
7. Select 'all projects' from the projects dropdown
8. Enter 'test' in the keyword filter

Actual results:
Item count is doubled both before and after the filter term is entered and duplicate items are being displayed on the page. Item count also does not match the number of items displayed on the page.

Expected results:
Duplicate items should not be displayed and item count should match the number of items displayed.

Additional info:
Suspect that packageManifest and marketPlacePackageManifest props retreived by firehose component contain overlapping results depending on what catalog sources are available and what namespace is selected. Probably need to either add a special case when all projects is selected, adjust our selectors to ensure no overlap, or add some logic after the call to reduce the package manifest props to a single unique list.
Comment 4 XiaochuanWang 2020-03-04 06:54:56 UTC 
Created attachment 1667399 [details]
tolerate duplicated operators in operatorhub
Comment 7 XiaochuanWang 2020-03-12 06:38:46 UTC 
Thank you for confirm! 
This should be fixed (Ignore the different name of packagemanifests which is not the original issue)
Verified on 4.5.0-0.nightly-2020-03-11-214319
Comment 8 tony.wu 2020-03-31 22:14:42 UTC 
Thanks, verifed the issue has been fixed on version: 4.5.0-0.nightly-2020-03-30-203132.

Not sure what's the process, do I still need to do anything with this bug?
Comment 10 errata-xmlrpc 2020-08-04 18:01:22 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5 image release advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409