Bug 1807133

Summary: Enable pipelines for Knative and Kubernetes apps on import
Product: OpenShift Container Platform Reporter: Andrew Ballantyne <aballant>
Component: Dev ConsoleAssignee: Andrew Ballantyne <aballant>
Status: CLOSED ERRATA QA Contact: spathak <spathak>
Severity: medium Docs Contact:
Priority: high    
Version: 4.4CC: aos-bugs, nmukherj, rgarg
Target Milestone: ---   
Target Release: 4.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Pipeline templates provided by the Operator had a Deployment Config specific deploy step, and would fail for Deployment and Knative Services Consequence: The Pipeline would build your app but not deploy it. Fix: Added support for the add flow to make use of the resource type as well as the builder to determine a Pipeline Result: Resource-specific support for Pipeline templates
 Story Points: ---
Clone Of: 1796185 Environment:
Last Closed: 2020-05-04 11:42:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1796185    
Bug Blocks: 1796186    
Attachments:
Description Flags
Enable pipelines for Knative and Kubernetes apps on import
none
Enable pipelines for Knative and Kubernetes apps on import-screenshot none

Description Andrew Ballantyne 2020-02-25 16:51:26 UTC 
+++ This bug was initially created as a clone of Bug #1796185 +++

Description of problem:
When selecting to add a pipeline from a runtime in the Add flows, it negates the understanding of the resource type that the pipeline may be in reference to.

Version-Release number of selected component (if applicable):
Noticed in 4.4, will need to be put back into 4.3.

How reproducible:


Steps to Reproduce:
1. Once a Pipeline is added to the `openshift` namespace with the appropriate label tying it to a runtime (ie pipeline.openshift.io/runtime:java - for the java runtime)
2. Navigate to the +Add flow and import from Git (or Dockerfile)
3. Notice that selecting the java runtime gets you the associated pipeline from the `openshift` namespace
4. Change your Resource type (Deployment, Deployment Config, Knative - if installed) and the pipeline is unaffected

Actual results:
Unable to associate a pipeline that may include internals for deployment vs knative for instance.


Expected results:
Being able to associate a pipeline to both a runtime as well as a resource type.


Additional info:
Logged first here https://issues.redhat.com/browse/ODC-2880 but needs backport to 4.3
Comment 3 Ruchir Garg 2020-03-02 06:38:36 UTC 
Bulk assigning all to Gajanan for verification.
Comment 4 spathak@redhat.com 2020-03-03 15:16:28 UTC 
Created attachment 1667211 [details]
Enable pipelines for Knative and Kubernetes apps on import
Comment 5 spathak@redhat.com 2020-03-03 15:19:27 UTC 
Verified on build : 4.4.0-0.ci-2020-03-03-033811
Chrome browser: 76.0.3809.132
Comment 6 spathak@redhat.com 2020-03-04 14:36:30 UTC 
Created attachment 1667505 [details]
Enable pipelines for Knative and Kubernetes apps on import-screenshot
Comment 8 errata-xmlrpc 2020-05-04 11:42:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581