Bug 1814396

Summary:	Still alert for SamplesInvalidConfig and SamplesMissingSecret events when samples operator set to removed during bootstrap
Product:	OpenShift Container Platform	Reporter:	Gabe Montero <gmontero>
Component:	Samples	Assignee:	Gabe Montero <gmontero>
Status:	CLOSED ERRATA	QA Contact:	XiuJuan Wang <xiuwang>
Severity:	high	Docs Contact:
Priority:	medium
Version:	4.3.z	CC:	xiuwang
Target Milestone:	---
Target Release:	4.3.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: samples operator would still send alerts about invalid configuration or missing image pull secrets when it was boostrapped as removed, meaning valid config or pull secrets are not required or set up Consequence: misleading and confusing alerts are provided to users Fix: samples operator was updated to not fire alerts related to importing samples when it was bootstrapped as removed Result: these confusing / misleading alerts when samples operator is removed are no longer sent	Story Points:	---
Clone Of:	1813175	Environment:
Last Closed:	2020-06-03 03:30:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1814395
Bug Blocks:

Description Gabe Montero 2020-03-17 18:54:30 UTC

+++ This bug was initially created as a clone of Bug #1813175 +++

Description of problem:
In ipv6 and disconnect installation, samples operator set to Removed during the bootstrap state. But still alert for SamplesInvalidConfig and SamplesMissingSecret events.

Version-Release number of selected component (if applicable):
4.4.0-0.nightly-2020-03-12-052849

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:

There is no 
$ oc describe config.samples cluster 
Name:         cluster
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  samples.operator.openshift.io/v1
Kind:         Config
Metadata:
  Creation Timestamp:  2020-03-13T04:18:10Z
  Finalizers:
    samples.operator.openshift.io/finalizer
  Generation:        1
  Resource Version:  17054
  Self Link:         /apis/samples.operator.openshift.io/v1/configs/cluster
  UID:               af601c7e-2508-486f-a5f4-0e921a01f5d7
Spec:
  Architectures:
    x86_64
  Management State:  Removed
Status:
  Conditions:
    Last Transition Time:  2020-03-13T04:18:16Z
    Last Update Time:      2020-03-13T04:18:16Z
    Status:                False
    Type:                  RemovePending
    Last Transition Time:  2020-03-13T04:18:13Z
    Last Update Time:      2020-03-13T04:18:13Z
    Status:                False
    Type:                  SamplesExist
    Last Transition Time:  2020-03-13T04:18:13Z
    Last Update Time:      2020-03-13T04:18:13Z
    Status:                False
    Type:                  ImageChangesInProgress
    Last Transition Time:  2020-03-13T04:18:13Z
    Last Update Time:      2020-03-13T04:18:13Z
    Status:                False
    Type:                  ImportImageErrorsExist
  Management State:        Removed
  Version:                 4.4.0-0.nightly-2020-03-12-052849
Events:                    <none>

$ oc describe co  openshift-samples  
Name:         openshift-samples
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  config.openshift.io/v1
Kind:         ClusterOperator
Metadata:
  Creation Timestamp:  2020-03-13T04:18:10Z
  Generation:          1
  Resource Version:    17017
  Self Link:           /apis/config.openshift.io/v1/clusteroperators/openshift-samples
  UID:                 ea0e8b22-a0ad-4e1a-a031-3e33b34f3349
Spec:
Status:
  Conditions:
    Last Transition Time:  2020-03-13T04:18:10Z
    Reason:                TermsBasedRegistryUnreacahable
    Status:                False
    Type:                  Progressing
    Last Transition Time:  2020-03-13T04:18:10Z
    Reason:                TermsBasedRegistryUnreacahable
    Status:                False
    Type:                  Degraded
    Last Transition Time:  2020-03-13T04:18:16Z
    Reason:                TermsBasedRegistryUnreacahable
    Status:                True
    Type:                  Available
  Extension:               <nil>
  Related Objects:
    Group:     samples.operator.openshift.io
    Name:      cluster
    Resource:  configs
    Group:     
    Name:      openshift-cluster-samples-operator
    Resource:  namespaces
    Group:     
    Name:      openshift
    Resource:  namespaces
  Versions:
    Name:     operator
    Version:  4.4.0-0.nightly-2020-03-12-052849
Events:       <none>

Expected results:
Should not alert for that events.

Additional info:
The managed status
 oc describe config.samples  
Name:         cluster
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  samples.operator.openshift.io/v1
Kind:         Config
Metadata:
  Creation Timestamp:  2020-03-12T02:47:28Z
  Finalizers:
    samples.operator.openshift.io/finalizer
  Generation:        1
  Resource Version:  13641
  Self Link:         /apis/samples.operator.openshift.io/v1/configs/cluster
  UID:               9b1bed13-a870-4936-94e3-96736bb83f4d
Spec:
  Architectures:
    x86_64
  Management State:  Managed
Status:
  Architectures:
    x86_64
  Conditions:
    Last Transition Time:  2020-03-12T02:47:28Z
    Last Update Time:      2020-03-12T02:47:28Z
    Status:                True
    Type:                  ImportCredentialsExist
    Last Transition Time:  2020-03-12T02:47:33Z
    Last Update Time:      2020-03-12T02:47:33Z
    Status:                True
    Type:                  ConfigurationValid
    Last Transition Time:  2020-03-12T02:47:28Z
    Last Update Time:      2020-03-12T02:47:31Z
    Status:                False
    Type:                  ImportImageErrorsExist
    Last Transition Time:  2020-03-12T02:47:39Z
    Last Update Time:      2020-03-12T02:47:39Z
    Status:                False
    Type:                  ImageChangesInProgress
    Last Transition Time:  2020-03-12T02:47:36Z
    Last Update Time:      2020-03-12T02:47:36Z
    Status:                True
    Type:                  SamplesExist
    Last Transition Time:  2020-03-12T02:47:33Z
    Last Update Time:      2020-03-12T02:47:33Z
    Status:                False
    Type:                  RemovePending
    Last Transition Time:  2020-03-12T02:47:33Z
    Last Update Time:      2020-03-12T02:47:33Z
    Status:                False
    Type:                  MigrationInProgress
  Management State:        Managed
  Version:                 4.4.0-0.nightly-2020-03-11-212258

--- Additional comment from XiuJuan Wang on 2020-03-13 07:35:35 UTC ---

Comment 1 Gabe Montero 2020-03-19 15:16:34 UTC

PR https://github.com/openshift/cluster-samples-operator/pull/251 is up but we have bugzilla bot hoopla with complaints about the dependent bug being 4.5 instead of 4.4

Comment 4 XiuJuan Wang 2020-05-26 06:19:30 UTC

Can't reproduce this issue on 4.3.0-0.nightly-2020-05-24-223407 disconnected cluster.

Comment 6 errata-xmlrpc 2020-06-03 03:30:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2256