Bug 1824280

Summary: fix registry override issues with jenkins; leverage import by sha with disconnected
Product: OpenShift Container Platform Reporter: Gabe Montero <gmontero>
Component: SamplesAssignee: Gabe Montero <gmontero>
Status: CLOSED ERRATA QA Contact: XiuJuan Wang <xiuwang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.4CC: wsun, xiuwang
Target Milestone: ---   
Target Release: 4.4.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: as part of providing disconnected support for sample in 4.2, samples operator had to allow for application of the samplesRegistry override to the CVO based jenkins imagestreams in order for the cvo install payload mirror to be used Consequence: that choice made use of samplesRegistry override in other scenarios more difficult, as the jenkins image spec from the CVO payload does not match analogous specs in quay.io or registry.redhat.io, which customers may have decided to mirror; plus the jenkins image on those registried breaks the special case support contract we have for the jenkins image as it being part of the base openshift install Fix: Now that the image registry can handle importing the jenkins imagestream when an install mirror is in place, the use of the samplesRegistry override is not longer need for the jenkins imagestreams Result: jenkins imagestream imports still work when the user uses samplesOverride to bring in the other samples imagestreams from somewhere other that registry.redhat.io
Story Points: ---
Clone Of: 1822381 Environment:
Last Closed: 2020-06-02 11:17:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1822381    
Bug Blocks: 1826028    

Comment 6 XiuJuan Wang 2020-05-26 09:26:23 UTC
Jenkins,jenkins-agent-maven,jenkins-agent-nodejs imagestreams could be imported successfully from payload in the disconnect cluster, and don't be overrided by samplesRegistry.
Verified in 4.4.0-0.nightly-2020-05-25-115719

Comment 8 Gabe Montero 2020-05-26 12:55:32 UTC
@XiuJuan my understanding of that card is that it essentially optimizes pull through.  It does not provide a path for disabling pull through.

Comment 9 XiuJuan Wang 2020-05-27 07:19:22 UTC
@Gabe
Before the card https://issues.redhat.com/browse/IR-34 implements, and samplesRegistry can't override jenkins imagestreams anymore, we should add release note how to do workaround.

Comment 10 Gabe Montero 2020-05-27 12:51:58 UTC
@XiuJuan

Perhaps I was not explicit enough, but https://issues.redhat.com/browse/IR-34 really does not have a bearing on
the jenkins related imagestreams and mirrors related to disconnected or registry override.


That said, we've got another round of doc improvements cooking with https://bugzilla.redhat.com/show_bug.cgi?id=1830946#c2
based on more customer experience,
where among other things clarification around the jenkins* imagestream special case is part of the updates I asked for.

If we want to craft a release note in the interim while Brandi sorts out that change, I'm amenable to that.  Please work
with her directly on that. Does QE open BZs against docs to ask for release notes?

Comment 11 XiuJuan Wang 2020-05-28 07:21:54 UTC
@Gabe
Open a doc bug #1841018 for 4.4 .
4.5 release note is under reviewing, will raise up this issue.

Thanks.

Comment 13 errata-xmlrpc 2020-06-02 11:17:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2310