Bug 1829567

Summary: Pipeline Builder Misunderstands Task 'default' Empty Value
Product: OpenShift Container Platform Reporter: Andrew Ballantyne <aballant>
Component: Dev ConsoleAssignee: Andrew Ballantyne <aballant>
Status: CLOSED ERRATA QA Contact: Gajanan More <gamore>
Severity: medium Docs Contact:
Priority: high    
Version: 4.4CC: aos-bugs, nmukherj, spathak
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Pipeline Builder incorrectly interpreted a default value of an empty string ('') as having no default. Consequence: Some operator provided tasks needed this to be the default and thus will have issues working without it. Fix: Check for a default property and not assume the validity of the value. Result: Should be able to respect anything the OpenShift Pipeline Operator deems as a valid default value.
 Story Points: ---
Clone Of:
: 1829568 (view as bug list) Environment:
Last Closed: 2020-07-13 17:32:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1829568    
Attachments:
Description Flags
Pipeline Builder Understands Task 'default' Empty Value none

Description Andrew Ballantyne 2020-04-29 19:21:54 UTC 
Description of problem:
Default value of an empty string is treated as not having a default value.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Navigate to the Pipeline Builder
2. Add the `maven` task
3. Click on the task bubble

Actual results:
Failure to understand which are required (none are)

Expected results:
No fields in the `maven` task should be required as they all have default values

Additional info:
Applies to all Task params that have a default value of an empty string
Comment 4 spathak@redhat.com 2020-05-27 15:12:25 UTC 
Created attachment 1692741 [details]
Pipeline Builder Understands Task 'default' Empty Value
Comment 5 spathak@redhat.com 2020-05-27 15:13:01 UTC 
Validated on build version: 4.5.0-0.nightly-2020-05-27-000432
Browser version: Firefox 73
Comment 6 errata-xmlrpc 2020-07-13 17:32:51 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409