Bug 183374
| Summary: | Review Request: perl-Crypt-Random | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-19 06:58:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 175198 | ||
| Bug Blocks: | 163779, 183889 | ||
|
Description
Paul Howarth
2006-02-28 18:09:56 UTC
perl-Math-Pari is stalled in review, but it doesn't look like there are any
issues (such as license) that would prevent the package from eventually being
accepted so I'll go ahead and review this.
A mock build is clean if the current perl-Math-Pari submission (2.010704-1) is
built and added to the repository. rpmlint is silent.
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible. It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
5730c9d5acdd698790216d354ffb0513 Crypt-Random-1.25.tar.gz
5730c9d5acdd698790216d354ffb0513 Crypt-Random-1.25.tar.gz-srpm
* package builds in mock (with dependencies added)
* BuildRequires are proper.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates, except for %{_bindir} which is mandated by FHS.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/Crypt, which will probably also be owned by
any module under the Crypt:: namespace. However, none of the dependencies
create this directory so there is no alternative but for this package to own it.
APPROVED, subject of course to the approval of perl-Math-Pari.
Thanks for the review.
7836 (perl-Crypt-Random): Build on target fedora-development-extras succeeded.
Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-development-extras/7836-perl-Crypt-Random-1.25-1.fc6/
Branch requests for FC-4 and FC-5 made.
Package Change Request ====================== Package Name: perl-Crypt-Random New Branches: EL-4 EL-5 cvs done. |