Red Hat Bugzilla – Bug 183374
Review Request: perl-Crypt-Random
Last modified: 2008-06-24 20:08:44 EDT
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-Random/perl-Crypt-Random.spec SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-Random/perl-Crypt-Random-1.25-1.src.rpm Description: Crypt::Random is an interface module to the /dev/random device found on most modern unix systems. It also interfaces with egd, a user space entropy gathering daemon, available for systems where /dev/random (or similar) devices are not available. When Math::Pari is installed, Crypt::Random can generate random integers of arbitrary size of a given bitsize or in a specified interval.
perl-Math-Pari is stalled in review, but it doesn't look like there are any issues (such as license) that would prevent the package from eventually being accepted so I'll go ahead and review this. A mock build is clean if the current perl-Math-Pari submission (2.010704-1) is built and added to the repository. rpmlint is silent. * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 5730c9d5acdd698790216d354ffb0513 Crypt-Random-1.25.tar.gz 5730c9d5acdd698790216d354ffb0513 Crypt-Random-1.25.tar.gz-srpm * package builds in mock (with dependencies added) * BuildRequires are proper. * no shared libraries are present. * package is not relocatable. * owns the directory it creates, except for %{_bindir} which is mandated by FHS. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * The package owns %{perl_vendorlib}/Crypt, which will probably also be owned by any module under the Crypt:: namespace. However, none of the dependencies create this directory so there is no alternative but for this package to own it. APPROVED, subject of course to the approval of perl-Math-Pari.
Thanks for the review. 7836 (perl-Crypt-Random): Build on target fedora-development-extras succeeded. Build logs may be found at http://buildsys.fedoraproject.org/logs/fedora-development-extras/7836-perl-Crypt-Random-1.25-1.fc6/ Branch requests for FC-4 and FC-5 made.
Package Change Request ====================== Package Name: perl-Crypt-Random New Branches: EL-4 EL-5
cvs done.