Bug 1867588

Summary: Review Request: perl-Test-Bits - Provides a bits_is() subroutine for testing binary data
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Test-Bits-0.02-1.fc34 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-21 10:44:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1867600, 1867617    

Description Petr Pisar 2020-08-10 12:35:57 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Test-Bits/perl-Test-Bits.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-Bits/perl-Test-Bits-0.02-1.fc33.src.rpm
Description:
This Perl module provides a single subroutine, bits_is(), for testing
binary data.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-20 13:55:12 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-Bits-0.02-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(List::AllUtils)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(parent)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Test::Builder::Module)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Bits-0.02-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Test::Bits) = 0.02
      1 perl-Test-Bits = 0.02-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Test-Bits*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 3 Igor Raits 2020-08-21 08:50:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Bits

Comment 4 Petr Pisar 2020-08-21 10:44:34 UTC
Thank you for the review and the repository.