Bug 1867617 - Review Request: perl-MaxMind-DB-Reader - Read MaxMind database files and look up IP addresses
Summary: Review Request: perl-MaxMind-DB-Reader - Read MaxMind database files and look...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1867162 1867561 1867588 1867600 1867611
Blocks: 1867967 1867999
TreeView+ depends on / blocked
 
Reported: 2020-08-10 13:49 UTC by Petr Pisar
Modified: 2020-08-24 06:11 UTC (History)
2 users (show)

Fixed In Version: perl-MaxMind-DB-Reader-1.000014-1.fc34
Clone Of:
Environment:
Last Closed: 2020-08-24 06:11:24 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-08-10 13:49:14 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Reader/perl-MaxMind-DB-Reader.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Reader/perl-MaxMind-DB-Reader-1.000014-1.fc33.src.rpm
Description:
This module provides a low-level interface to the MaxMind database file format
<http://maxmind.github.io/MaxMind-DB/>.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-21 11:11:54 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MaxMind-DB-Reader-1.000014-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(autodie)
      1 perl(bytes)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Data::IEEE754)
      1 perl(Data::Printer)
      1 perl(Data::Validate::IP) >= 0.25 
      1 perl(Encode)
      1 perl(Getopt::Long)
      1 perl(List::AllUtils)
      1 perl(Math::BigInt)
      1 perl(MaxMind::DB::Common) >= 0.040001
      1 perl(MaxMind::DB::Metadata)
      1 perl(MaxMind::DB::Reader)
      1 perl(MaxMind::DB::Reader::Data::Container)
      1 perl(MaxMind::DB::Reader::Data::EndMarker)
      1 perl(MaxMind::DB::Reader::Decoder)
      1 perl(MaxMind::DB::Types)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Module::Implementation)
      1 perl(Moo) >= 1.003000
      1 perl(Moo::Role)
      1 perl(MooX::StrictConstructor)
      1 perl(namespace::autoclean)
      1 perl(Role::Tiny) >= 1.003002
      1 perl(Socket) >= 1.87
      1 perl(strict)
      1 perl(:VERSION) >= 5.10.0
      1 perl(warnings) 
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-MaxMind-DB-Reader-1.000014-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(MaxMind::DB::Reader) = 1.000014
      1 perl-MaxMind-DB-Reader = 1.000014-1.fc34
      1 perl(MaxMind::DB::Reader::Data::Container) = 1.000014
      1 perl(MaxMind::DB::Reader::Data::EndMarker) = 1.000014
      1 perl(MaxMind::DB::Reader::Decoder) = 1.000014
      1 perl(MaxMind::DB::Reader::PP) = 1.000014
      1 perl(MaxMind::DB::Reader::Role::HasDecoder) = 1.000014
      1 perl(MaxMind::DB::Reader::Role::HasMetadata) = 1.000014
      1 perl(MaxMind::DB::Reader::Role::NodeReader) = 1.000014
      1 perl(MaxMind::DB::Reader::Role::Reader) = 1.000014
      1 perl(MaxMind::DB::Reader::Role::Sysreader) = 1.000014
Binary provides are Ok.

$ rpmlint ./perl-MaxMind-DB-Reader*
perl-MaxMind-DB-Reader.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
perl-MaxMind-DB-Reader.noarch: W: no-manual-page-for-binary mmdb-dump-metadata
perl-MaxMind-DB-Reader.noarch: W: no-manual-page-for-binary mmdb-dump-search-tree
perl-MaxMind-DB-Reader.src: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-08-21 13:48:07 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MaxMind-DB-Reader

Comment 4 Petr Pisar 2020-08-24 06:11:24 UTC
Thank you for the review and the repository.

I realized that excluding 32-bit architectures is not needed for this package and reworked the conditions to be buildable everywhere.


Note You need to log in before you can comment on or make changes to this bug.