Bug 1867600 - Review Request: perl-Data-IEEE754 - Pack and unpack big-endian IEEE 754 floats and doubles
Summary: Review Request: perl-Data-IEEE754 - Pack and unpack big-endian IEEE 754 float...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1867588
Blocks: 1867617
TreeView+ depends on / blocked
 
Reported: 2020-08-10 13:03 UTC by Petr Pisar
Modified: 2020-08-21 11:03 UTC (History)
2 users (show)

Fixed In Version: perl-Data-IEEE754-0.02-1.fc34
Clone Of:
Environment:
Last Closed: 2020-08-21 11:03:56 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-08-10 13:03:31 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Data-IEEE754/perl-Data-IEEE754.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Data-IEEE754/perl-Data-IEEE754-0.02-1.fc33.src.rpm
Description:
This Perl module provides some simple convenience functions for packing and
unpacking IEEE 754 floats and doubles. If you can require Perl 5.10 or greater
then this module is pointless. Just use the "d>" and "f>" pack formats
instead.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-20 14:53:17 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Data-IEEE754-0.02-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Config)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Data-IEEE754-0.02-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Data::IEEE754) = 0.02
      1 perl-Data-IEEE754 = 0.02-1.fc34 
Binary provides are Ok.

$ rpmlint ./perl-Data-IEEE754*
perl-Data-IEEE754.noarch: W: spelling-error Summary(en_US) endian -> Indian, ending
perl-Data-IEEE754.src: W: spelling-error Summary(en_US) endian -> Indian, ending
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 3 Igor Raits 2020-08-21 08:50:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-IEEE754

Comment 4 Petr Pisar 2020-08-21 11:03:56 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.