Bug 1867600

Summary:	Review Request: perl-Data-IEEE754 - Pack and unpack big-endian IEEE 754 floats and doubles
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Data-IEEE754-0.02-1.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-21 11:03:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1867588
Bug Blocks:	1867617

Description Petr Pisar 2020-08-10 13:03:31 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Data-IEEE754/perl-Data-IEEE754.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Data-IEEE754/perl-Data-IEEE754-0.02-1.fc33.src.rpm
Description:
This Perl module provides some simple convenience functions for packing and
unpacking IEEE 754 floats and doubles. If you can require Perl 5.10 or greater
then this module is pointless. Just use the "d>" and "f>" pack formats
instead.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-20 14:53:17 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Data-IEEE754-0.02-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Config)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Data-IEEE754-0.02-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Data::IEEE754) = 0.02
      1 perl-Data-IEEE754 = 0.02-1.fc34 
Binary provides are Ok.

$ rpmlint ./perl-Data-IEEE754*
perl-Data-IEEE754.noarch: W: spelling-error Summary(en_US) endian -> Indian, ending
perl-Data-IEEE754.src: W: spelling-error Summary(en_US) endian -> Indian, ending
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 2 Petr Pisar 2020-08-21 07:10:55 UTC

https://pagure.io/releng/fedora-scm-requests/issue/27726

Comment 3 Igor Raits 2020-08-21 08:50:55 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-IEEE754

Comment 4 Petr Pisar 2020-08-21 11:03:56 UTC

Thank you for the review and the repository.