Bug 1867611

Summary: Review Request: perl-Net-Works - API for IP addresses and networks
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Net-Works-0.22-1.fc34 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-24 07:26:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1867162    
Bug Blocks: 1867617    

Description Petr Pisar 2020-08-10 13:26:39 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Net-Works/perl-Net-Works.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Net-Works/perl-Net-Works-0.22-1.fc33.src.rpm
Description:
The NetAddr::IP module is very complete, correct, and useful. However, its
API design is a bit crufty. This package provides an alternative API that
aims to address the biggest problems with that module's API, as well as
adding some additional features.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2020-08-20 12:14:28 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-Works-0.22-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(integer)
      1 perl(List::AllUtils)
      1 perl(Math::Int128) >= 0.06 
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Moo)
      1 perl(Moo::Role)
      1 perl(namespace::autoclean) >= 0.16 
      1 perl(Net::Works::Address)
      1 perl(Net::Works::Types)
      1 perl(Net::Works::Util)
      1 perl(overload) 
      1 perl(Scalar::Util)
      1 perl(Socket) >= 1.99
      1 perl(strict)
      1 perl(Sub::Quote)
      1 perl(:VERSION) >= 5.10.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Net-Works-0.22-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Net::Works) = 0.22
      1 perl-Net-Works = 0.22-1.fc34
      1 perl(Net::Works::Address) = 0.22
      1 perl(Net::Works::Network) = 0.22
      1 perl(Net::Works::Role::IP) = 0.22
      1 perl(Net::Works::Types) = 0.22
      1 perl(Net::Works::Util) = 0.22
Binary provides are Ok.

$ rpmlint ./perl-Net-Works*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved
Comment 2 Petr Pisar 2020-08-20 12:40:24 UTC 
https://pagure.io/releng/fedora-scm-requests/issue/27674
Comment 3 Gwyn Ciesla 2020-08-20 15:34:07 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-Works
Comment 4 Petr Pisar 2020-08-21 07:38:24 UTC 
Thank you for the review and the repository.

I will create the bugs for the excluded architectures once a component emerged in Bugzilla.