Bug 1867162 - Review Request: perl-Math-Int128 - Manipulate 128 bits integers in Perl
Summary: Review Request: perl-Math-Int128 - Manipulate 128 bits integers in Perl
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1867611 1867617 1867967
TreeView+ depends on / blocked
 
Reported: 2020-08-07 14:31 UTC by Petr Pisar
Modified: 2020-08-24 07:26 UTC (History)
2 users (show)

Fixed In Version: perl-Math-Int128-0.22-1.fc34
Clone Of:
Environment:
Last Closed: 2020-08-24 07:26:26 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-08-07 14:31:38 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Math-Int128/perl-Math-Int128.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Math-Int128/perl-Math-Int128-0.22-1.fc33.src.rpm
Description:
This module adds support for 128-bit integers, signed and unsigned, to Perl.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-20 09:33:21 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Math-Int128-0.22-1.fc34.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.32()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit) 
      1 perl(constant)
      1 perl(Exporter)
      1 perl(Math::Int64) >= 0.51
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Math-Int128-0.22-1.fc34.x86_64.rpm | sort | uniq -c
      1 perl(Math::Int128) = 0.22
      1 perl-Math-Int128 = 0.22-1.fc34 
      1 perl(Math::Int128::die_on_overflow) = 0.22
      1 perl-Math-Int128(x86-64) = 0.22-1.fc34
      1 perl(Math::UInt128)
Binary provides are Ok.

$ rpmlint ./perl-Math-Int128*
perl-Math-Int128.x86_64: E: non-standard-executable-perm /usr/lib64/perl5/vendor_perl/auto/Math/Int128/Int128.so 555
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
TODO: Please check the permission

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-08-20 15:33:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Math-Int128

Comment 4 Petr Pisar 2020-08-21 07:28:01 UTC
Thank you for the review and the repository.

I will create the bugs for the excluded architectures once the component emerged in Bugzilla.


Note You need to log in before you can comment on or make changes to this bug.