Bug 1875383

Summary:	terminationGracePeriodSeconds should be updated in VMs created from common templates
Product:	Container Native Virtualization (CNV)	Reporter:	Ruth Netser <rnetser>
Component:	Documentation	Assignee:	Andrew Burden <aburden>
Status:	CLOSED ERRATA	QA Contact:	Ruth Netser <rnetser>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	2.4.1	CC:	aburden, aspauldi, cnv-qe-bugs, ctomasko, ipinto
Target Milestone:	---
Target Release:	2.4.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	2.4.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-06 23:54:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ruth Netser 2020-09-03 12:31:15 UTC

Document URL: 

Section Number and Name: 

Describe the issue: 
Bug 1859235 and bug 1856412 result with 2 templates for each OS, which may led to a VM created with terminationGracePeriodSeconds 0 (taken from the previous templates version).
The new temlates have the correct value for terminationGracePeriodSeconds(fixed in bug 1861297)
When a VM is created from common templates (or via the UI using the wizard), please verify that terminationGracePeriodSeconds is not 0. If it is, update is to 180 (linux-based) or 3600 (windows-based) in the VM yaml.


Suggestions for improvement: 

Additional information:

Comment 1 Audrey Spaulding 2020-09-04 18:36:38 UTC

@rnetser, is this intended as a release note?

Comment 2 Ruth Netser 2020-09-06 07:18:35 UTC

@aspauldi - yes

Comment 3 Audrey Spaulding 2020-09-18 15:11:17 UTC

@rnetser, what info are you waiting for from me?

Comment 4 Ruth Netser 2020-09-21 08:11:22 UTC

@aspauldi - was just a response to https://bugzilla.redhat.com/show_bug.cgi?id=1875383#c1
Nothing is needed from my side.

Comment 5 Andrew Burden 2020-09-22 18:27:53 UTC

There was an existing Release Note (BZ#1859237) about there being two versions of each common-template after upgrade. I've amended that and added a step for how to verify if a virtual machine has been created from an older version (terminationGracePeriod: 0), and also how to patch it with an appropriate value if necessary.

PR: https://github.com/openshift/openshift-docs/pull/25685
Build:  https://cnv-bz1875383-grace-period--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virt-2-4-release-notes.html#virt-2-4-known-issues (3rd Known Issue from top)

Ruth, can you please review. Thank you!

Comment 6 Audrey Spaulding 2020-09-22 20:46:41 UTC

(In reply to Ruth Netser from comment #4)
> @aspauldi - was just a response to
> https://bugzilla.redhat.com/show_bug.cgi?id=1875383#c1
> Nothing is needed from my side.

Thank you, Ruth!

Comment 7 Ruth Netser 2020-10-06 11:34:26 UTC

Please see my comment in the PR.

Comment 8 Ruth Netser 2020-10-06 11:34:26 UTC

Please see my comment in the PR.

Comment 9 Andrew Burden 2020-10-06 14:07:25 UTC

Thanks Ruth
PR updated: Added a note and slightly rewrote so that users with VMs created from common templates prior to upgrade will also pay attention to the workaround

Comment 10 Ruth Netser 2020-10-06 14:25:09 UTC

Reviewed, added /lgtm in the PR

Comment 16 errata-xmlrpc 2020-10-06 23:54:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: OpenShift Virtualization 2.4.2 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4201