Bug 1882739
Summary: | Restore Snapshot page should not allow to select a Storage Class with a different RBD pool than parent volume's | |||
---|---|---|---|---|
Product: | [Red Hat Storage] Red Hat OpenShift Container Storage | Reporter: | Neha Berry <nberry> | |
Component: | documentation | Assignee: | Kusuma <kbg> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | akarsha <akrai> | |
Severity: | high | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 4.6 | CC: | aos-bugs, asriram, bkunal, etamir, hchiramm, kbg, mrajanna, muagarwa, nthomas, ocs-bugs, ygalanti | |
Target Milestone: | --- | Keywords: | Documentation | |
Target Release: | OCS 4.6.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | If docs needed, set a value | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1901954 (view as bug list) | Environment: | ||
Last Closed: | 2021-07-05 11:10:55 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1901954 |
Description
Neha Berry
2020-09-25 13:59:46 UTC
> @Neha, we have fixed the create button issue with this bug -> https://bugzilla.redhat.com/show_bug.cgi?id=1870339, so user wont be able to restore the snapshot if they haven't selected any storage class. I have following questions regarding this bug:- 1. We already filter the storage classes that have same provisioner, does it has to be parent's storage Class itself, or all same provisioner based storage classes are supported in downstream? "The Pool" inside the SC is the key here. > 2. We can filter on the bases of pool name used for parent pvc, but this filtering wont be possible if user deletes the parent pvc and then tries to restore the snapshot. This is because we will loose the information about storageClass name of parent, and hence the pool name. So, either we can add filter that works if parent pvc exist and doesnt work if no parent pvc is there. Or should we document this behavior of restore instead? > Are we supporting multiple SC with same POOL in OCS 4.6? > > Are we supporting multiple SC with same POOL in OCS 4.6? Yes, we are supporting multiple SC with same POOL, fixed with this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1878075 (In reply to Kanika Murarka from comment #6) > > > > Are we supporting multiple SC with same POOL in OCS 4.6? > > Yes, we are supporting multiple SC with same POOL, fixed with this BZ: > https://bugzilla.redhat.com/show_bug.cgi?id=1878075 OK.. If thats the case, we can not assume 'SC' while restoring. The pool can be derived, but I dont think its something UI can do or right thing to do. Otherwise the POOL has to be part of snapshotclass or we have to record it explictly in the snapshot object for consumers to make use of it.
> OK.. If thats the case, we can not assume 'SC' while restoring. The pool can
> be derived, but I dont think its something UI can do or right thing to do.
> Otherwise the POOL has to be part of snapshotclass or we have to record it
> explictly in the snapshot object for consumers to make use of it.
+1, If will be useful if we can get pool information stored in snapshot object
Since we already filter the storage class for the specific provider, we need to stop here. The reason is that this is a UI used for all providers, not just OCS. Pool is not a general terminology and irrelevant for other providers. The only thing we can do is to mention it in our documentation - @anjana Thanks Eran, Moving the BZ to documentation component. In doc [1] after step select storage class name, on note have added: You must select a storage class which is attached to the same pool as that of the parent PVC. Looks good, so moving the bz to verified state. [1]: https://access.redhat.com/documentation/en-us/red_hat_openshift_container_storage/4.6/html-single/managing_and_allocating_storage_resources/index?lb_target=preview#restoring-volume-snapshots_rhocs Considering this is getting addressed in code, can we close this bugzilla? (In reply to Humble Chirammal from comment #26) > Considering this is getting addressed in code, can we close this bugzilla? Once we have the fix in code (hopefully 4.8) we need to change the documentation. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days |