Bug 188380

Summary: Review Request: perl-Test-Deep
Product: [Fedora] Fedora Reporter: Steven Pritchard <steve>
Component: Package ReviewAssignee: Jason Tibbitts <tibbs>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: paul, perl-devel
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-04-10 20:59:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 163779, 188376, 188378    

Description Steven Pritchard 2006-04-08 19:37:23 UTC
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Test-Deep/perl-Test-Deep.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Test-Deep-0.093-1.src.rpm
Description:
Test::Deep gives you very flexible ways to check that the result you
got is the result you were expecting. At it's simplest it compares two
structures by going through each level, ensuring that the values
match, that arrays and hashes have the same elements and that
references are blessed into the correct class. It also handles
circular data structures without getting caught in an infinite loop.

Comment 1 Jason Tibbitts 2006-04-10 03:09:25 UTC
The package builds in mock (development branch, with dependencies added) and
rpmlint is silent.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   b47659e09457a72157d3db5b5be62f75  Test-Deep-0.093.tar.gz
   b47659e09457a72157d3db5b5be62f75  Test-Deep-0.093.tar.gz-srpm
* package builds in mock.
* BuildRequires are proper.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/Test, which will probably also be owned by
any module under the Test:: namespace.  However, none of the dependencies create
this directory so there is no alternative.
APPROVED

Comment 2 Steven Pritchard 2006-04-10 20:59:47 UTC
Imported into CVS and builds requested.

Comment 3 Paul Howarth 2011-01-18 10:38:45 UTC
Hi Steve,

I see that there are existing EL-4 branches for perl-Test-Deep and its dependency perl-Test-NoWarnings but they haven't been built. I've tried building the packages in mock as they stand and they build OK, so is there some reason why they're not built for EPEL-4?

If you're no longer interested in EPEL-4 I'll happily take those branches off your hands.

Comment 4 Steven Pritchard 2011-01-18 19:53:31 UTC
I had my packages mass-branched for EPEL when it started.  I think there are still a lot of my packages that haven't been built for whatever reason.  If you want to build those, go for it.  (If you want to add yourself to those branches in pkgdb, go for it, but I'll watch for bugs either way.)

Comment 5 Fedora Update System 2011-02-03 18:19:09 UTC
perl-Test-Deep-0.096-1.el4 has been submitted as an update for Fedora EPEL 4.
https://admin.fedoraproject.org/updates/perl-Test-Deep-0.096-1.el4

Comment 6 Fedora Update System 2011-02-19 00:24:00 UTC
perl-Test-Deep-0.096-1.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.