Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Test-Tester/perl-Test-Tester.spec SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Test-Tester-0.103-1.src.rpm Description: If you have written a test module based on Test::Builder then Test::Tester allows you to test it with the minimum of effort.
It looks like the dependencies are backwards on this; it's a requirement for perl-Test-Deep, not the other way around. So I'll just review all of them.
Builds fine in mock (development branch) and rpmlint is silent. Issues: The package says it's under the same license as perl, but then includes the file "ARTISTIC" and makes no mention of the GPL. Odd; upstream should be whacked, but not a blocker. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible and license text is included in the package. * source files match upstream: 31d58158d2a6cdb7ad9d9fe3e0aed86e Test-Tester-0.103.tar.gz 31d58158d2a6cdb7ad9d9fe3e0aed86e Test-Tester-0.103.tar.gz-srpm * package builds in mock. * BuildRequires are proper. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directory it creates. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %test is present and all tests pass. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * The package owns %{perl_vendorlib}/Test, which will probably also be owned by any module under the Test:: namespace. However, none of the dependencies create this directory so there is no alternative but for this package to own it. APPROVED
Oops, sorry about the order of the dependencies. Imported into CVS and builds requested.