Bug 1888972

Summary: Review Request: golang-github-shurcool-githubv4 - A client library for accessing GitHub GraphQL API v4
Product: [Fedora] Fedora Reporter: Joe Doss <joe>
Component: Package ReviewAssignee: Jared Smith <jsmith.fedora>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 33CC: eclipseo, jsmith.fedora, package-review
Target Milestone: ---Flags: jsmith.fedora: fedora-review?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-05 07:13:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1888971    
Bug Blocks:    

Comment 1 Jared Smith 2020-10-27 16:12:58 UTC
ERROR: Command failed:
 # /usr/bin/dnf builddep --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/golang-github-shurcool-githubv4-0-0.1.20201001gitbc5e4fe.fc34.src.rpm --setopt=tsflags=nocontexts
No matches found for the following disable plugin patterns: local, spacewalk
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
fedora                                          9.6 kB/s | 5.8 kB     00:00
fedora                                          695 kB/s | 3.0 MB     00:04
Last metadata expiration check: 0:00:25 ago on Tue Oct 27 12:08:38 2020.
No matching package to install: 'golang(github.com/cli/shurcooL-graphql)'
Not all dependencies satisfied
Error: Some packages could not be found.

Comment 2 Joe Doss 2020-10-27 17:24:39 UTC
Sorry! You need to build this first:

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Comment 3 Joe Doss 2020-10-30 13:21:10 UTC
Hey Jared,

https://src.fedoraproject.org/rpms/golang-github-cli-shurcool-graphql is in rawhide now so you should be able to build this package and approve it.

Thanks,
Joe

Comment 4 Robert-André Mauchin 🐧 2020-11-05 07:13:55 UTC
Seems I already built it two months ago, probably as a new dep for an update:

https://src.fedoraproject.org/rpms/golang%2Dgithub%2Dshurcool%2Dgithubv4

Comment 5 Joe Doss 2020-11-06 14:16:57 UTC
Then how should I handled there requirement for GitHub CLI needed their forked github.com/cli/shurcooL-graphql until https://github.com/shurcooL/graphql/pull/57 gets merged?

# BuildRequires:  golang(github.com/shurcooL/graphql)
# Use GitHub's fork until https://github.com/shurcooL/graphql/pull/57 gets merged.
BuildRequires:  golang(github.com/cli/shurcooL-graphql)

Using what is built won't work in https://bugzilla.redhat.com/show_bug.cgi?id=1803302 without https://github.com/shurcooL/graphql/pull/57

Comment 6 Robert-André Mauchin 🐧 2020-11-07 03:33:56 UTC
Do a sed -i "s|github.com/shurcooL/graphql|github.com/cli/shurcooL-graphql|" $(find . -name "*.go") in prep