Bug 1897888

Summary:	[RFE] Refine "hosted-engine --check-deployed" results.
Product:	[oVirt] ovirt-hosted-engine-setup	Reporter:	Nikolai Sednev <nsednev>
Component:	RFEs	Assignee:	Aviv Turgeman <aturgema>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nikolai Sednev <nsednev>
Severity:	medium	Docs Contact:
Priority:	low
Version:	2.4.8	CC:	arachman, aturgema, bugs, sbonazzo
Target Milestone:	ovirt-4.4.4	Keywords:	FutureFeature, Triaged
Target Release:	2.4.9	Flags:	aturgema: needinfo- sbonazzo: ovirt-4.4? pm-rhel: planning_ack? sbonazzo: devel_ack+ pm-rhel: testing_ack+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-hosted-engine-setup-2.4.9	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-21 12:36:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nikolai Sednev 2020-11-15 10:46:58 UTC

Description of problem:
1.When you run "hosted-engine --check-deployed" on ha-host on which deployment was made, you don't receive anything:
"alma07 ~]# hosted-engine --check-deployed
[root@alma07 ~]# "
Please refine with appropriate message, just like you do for hosts on which HE was not deployed.



Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-2.4.8-1.el8ev.noarch
ovirt-hosted-engine-ha-2.4.5-1.el8ev.noarch


How reproducible:
100%

Steps to Reproduce:
1.Deploy HE on host.
2.Run "hosted-engine --check-deployed" on host.

Actual results:
Command returns nothing.

Expected results:
Command should return meaningful message.

Comment 1 Asaf Rachmani 2020-11-15 13:15:28 UTC

AFAIU the '--check-deployed' has been added in order to use it in the cockpit-ovirt (please have a look at bug 1318415 that depends on bug 1324921).
You can use '--vm-status' to detect if the hosted-engine has been deployed or hasn't.

Aviv, 
Will it break something in cockpit-ovirt, if we change the '--check-deployed' and print a message also for deployed hosted engine?

Comment 2 Aviv Turgeman 2020-11-15 15:52:24 UTC

(In reply to Asaf Rachmani from comment #1)

> Aviv, 
> Will it break something in cockpit-ovirt, if we change the
> '--check-deployed' and print a message also for deployed hosted engine?

Hi,
I checked the code of cockpit-ovirt, and it shouldn't break anything to add output to console, but didn't verified it yet.
I will make some tests to see the results of it.

Comment 3 Nikolai Sednev 2020-11-29 12:31:03 UTC

ovirt-hosted-engine-ha-2.4.5-1.el8ev.noarch
ovirt-hosted-engine-setup-2.4.9-1.el8ev.noarch
alma07 ~]# hosted-engine --check-deployed
The hosted engine has been deployed

Comment 4 Sandro Bonazzola 2020-12-21 12:36:44 UTC

This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.