Bug 1900274

Summary:	Review Request: rust-leb128 - DWARF's LEB128 encoding library and REPL
Product:	[Fedora] Fedora	Reporter:	Olivier Lemasle <o.lemasle>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, eclipseo, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-01-20 19:43:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1901090

Description Olivier Lemasle 2020-11-21 21:09:30 UTC

Spec URL: https://olem.fedorapeople.org/reviews/rust-leb128.spec
SRPM URL: https://olem.fedorapeople.org/reviews/rust-leb128-0.2.4-1.fc33.src.rpm

Description:
Read and write DWARF's "Little Endian Base 128" (LEB128) variable length
integer encoding.

Fedora Account System Username: olem

Comment 1 Olivier Lemasle 2020-11-21 21:09:33 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=56029700

Comment 2 Fabio Valentini 2021-01-04 12:44:11 UTC

Package generated with rust2rpm, simplifying review process.

- package builds and installs on rawhide
- License is correct (both for library and statically linked binary, since it has no external dependencies)
- package follows Rust packaging Guidelines
- Patches / PRs / divergence from rust2rpm-generated spec file justified

Package APPROVED.

Suggestions for improvement:

Make names of patches and comments for them more descriptive, e.g.:

# Use latest version of dependency
Patch0:         dependency-version.diff
# Add exclusions to Cargo.toml
# Cf. upstream PR: https://github.com/gimli-rs/leb128/pull/17
Patch1:         exclude.diff

becomes:

# Initial patched metadata
# * bump quickcheck from 0.8 to 0.9
# * exclude unnecessary CI files
Patch0:         leb128-fix-metadata.diff

The filename is in line with what "rust2rpm -p" generates, and so this would also match other Rust packages.


Could you review one of my pending Rust packages in return?

Comment 3 Olivier Lemasle 2021-01-04 23:18:45 UTC

Thank you for your review. Sure, I'll review your packages; I'll do it this week.

Comment 4 Gwyn Ciesla 2021-01-05 14:33:04 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-leb128