Spec URL: https://olem.fedorapeople.org/reviews/rust-leb128.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-leb128-0.2.4-1.fc33.src.rpm Description: Read and write DWARF's "Little Endian Base 128" (LEB128) variable length integer encoding. Fedora Account System Username: olem
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=56029700
Package generated with rust2rpm, simplifying review process. - package builds and installs on rawhide - License is correct (both for library and statically linked binary, since it has no external dependencies) - package follows Rust packaging Guidelines - Patches / PRs / divergence from rust2rpm-generated spec file justified Package APPROVED. Suggestions for improvement: Make names of patches and comments for them more descriptive, e.g.: # Use latest version of dependency Patch0: dependency-version.diff # Add exclusions to Cargo.toml # Cf. upstream PR: https://github.com/gimli-rs/leb128/pull/17 Patch1: exclude.diff becomes: # Initial patched metadata # * bump quickcheck from 0.8 to 0.9 # * exclude unnecessary CI files Patch0: leb128-fix-metadata.diff The filename is in line with what "rust2rpm -p" generates, and so this would also match other Rust packages. Could you review one of my pending Rust packages in return?
Thank you for your review. Sure, I'll review your packages; I'll do it this week.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-leb128