Bug 190362
| Summary: | Review Request: unifdef | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Woodhouse <dwmw2> | ||||
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jose.p.oliveira.oss, spacewar | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | Flags: | j:
fedora-cvs+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | unifdef-1.171-10.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-05-18 00:39:13 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 189937 | ||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
David Woodhouse
2006-05-01 16:27:54 UTC
Given the review done in 189937 I'm going to approve this package for Extras. Created attachment 128452 [details]
unidef.spec.patch - dist tag and other minor modifications
Patch:
* adds a dist tag
* silences the setup setup (-q option)
* replaces "mkdir -p" by "install -d -m0755"
* preserves the file timestamps (install -p)
* adds a blank line between the %setup and %build sections
thanks. Updated specfile and src.rpm at http://david.woodhou.se/unifdef.spec and http://david.woodhou.se/unifdef-1.171-3.src.rpm David, Don't forget to update the changelog ... $ rpmlint /home/users/fedora/rpms/RPMS/i386/unifdef-1.171-3.i386.rpm W: unifdef incoherent-version-in-changelog 1.171-2 1.171-3 /jpo The CVS branches for FC-4 and FC-5 are still missing.
The request must be placed here:
http://fedoraproject.org/wiki/Extras/CVSSyncNeeded
Unless I was hallucinating, it _was_ added there. I added it again. Does the Wiki let you see any more history than the one most recent change? Ah. I mistyped the package name as 'unidef' and Warren removed it without comment. Package has been imported. Please remember to close package reviews once accepted and imported. Re-opening this ticket until: * package is built for FC-4 and FC-5 (cvs branches already in place) * the rawhide version-release is bigger or equal to the extras VR * files removed from the devel branch * the missing changelog entry is added ;) David, Could you see the last paragraphs of http://fedoraproject.org/wiki/Extras/CVSSyncNeeded regarding the removal of the devel branch files? TIA, jpo Removed. Package Change Request ====================== Package Name: unifdef New Branches: F-13 Owners: brouhaha There is already a F-13 branch. Make sure you do a 'cvs update -d' to pick up the directories. Feel free to reset the cvs flag if you need anything further. Package Change Request ====================== Package Name: unifdef New Branches: el6 Owners: brouhaha Git done (by process-git-requests). unifdef-1.171-10.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/unifdef-1.171-10.el6 unifdef-1.171-10.el6 has been pushed to the Fedora EPEL 6 stable repository. |