Bug 190362 - Review Request: unifdef
Review Request: unifdef
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Cantrell
Fedora Package Reviews List
: Reopened
Depends On: 189937
  Show dependency treegraph
Reported: 2006-05-01 12:27 EDT by David Woodhouse
Modified: 2013-01-09 20:23 EST (History)
2 users (show)

See Also:
Fixed In Version: unifdef-1.171-10.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-05-17 20:39:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑cvs+

Attachments (Terms of Use)
unidef.spec.patch - dist tag and other minor modifications (1.12 KB, patch)
2006-05-01 13:19 EDT, Jose Pedro Oliveira
no flags Details | Diff

  None (edit)
Description David Woodhouse 2006-05-01 12:27:54 EDT
Spec URL: http://david.woodhou.se/unifdef.spec
SRPM URL: http://david.woodhou.se/unifdef-1.171-2.src.rpm
Unifdef is useful for removing ifdefed lines from a file while otherwise
leaving the file alone. Unifdef acts on #ifdef, #ifndef, #else, and #endif
lines, and it knows only enough about C and C++ to know when one of these
is inactive because it is inside a comment, or a single or double quote.

This is already in Core for rawhide. Could do with FC4 and FC5 builds in Extras though.
Comment 1 Jesse Keating 2006-05-01 12:50:47 EDT
Given the review done in 189937 I'm going to approve this package for Extras.
Comment 2 Jose Pedro Oliveira 2006-05-01 13:19:25 EDT
Created attachment 128452 [details]
unidef.spec.patch - dist tag and other minor modifications

* adds a dist tag
* silences the setup setup (-q option)
* replaces "mkdir -p" by "install -d -m0755" 
* preserves the file timestamps (install -p)
* adds a blank line between the %setup and %build sections
Comment 3 David Woodhouse 2006-05-01 16:34:31 EDT
thanks. Updated specfile and src.rpm at 
 http://david.woodhou.se/unifdef.spec and
Comment 4 Jose Pedro Oliveira 2006-05-01 21:02:32 EDT

Don't forget to update the changelog ...

  $ rpmlint /home/users/fedora/rpms/RPMS/i386/unifdef-1.171-3.i386.rpm 
  W: unifdef incoherent-version-in-changelog 1.171-2 1.171-3

Comment 5 Jose Pedro Oliveira 2006-05-07 12:14:21 EDT
The CVS branches for FC-4 and FC-5 are still missing. 
The request must be placed here:
Comment 6 David Woodhouse 2006-05-07 12:20:51 EDT
Unless I was hallucinating, it _was_ added there. I added it again.

Does the Wiki let you see any more history than the one most recent change?
Comment 7 David Woodhouse 2006-05-07 12:25:06 EDT
Ah. I mistyped the package name as 'unidef' and Warren removed it without comment.
Comment 8 Michael J Knox 2006-05-08 00:33:45 EDT
Package has been imported. Please remember to close package reviews once
accepted and imported. 
Comment 9 Jose Pedro Oliveira 2006-05-10 15:54:43 EDT
Re-opening this ticket until:
 * package is built for FC-4 and FC-5 (cvs branches already in place)
 * the rawhide version-release is bigger or equal to the extras VR
 * files removed from the devel branch
 * the missing changelog entry is added ;) 
Comment 10 Jose Pedro Oliveira 2006-05-17 20:34:51 EDT

Could you see the last paragraphs of 
regarding the removal of the devel branch files?

Comment 11 David Woodhouse 2006-05-17 20:39:13 EDT
Comment 12 Eric Smith 2010-04-07 10:47:56 EDT
Package Change Request
Package Name: unifdef
New Branches: F-13
Owners: brouhaha
Comment 13 Kevin Fenzi 2010-04-07 22:17:41 EDT
There is already a F-13 branch. 

Make sure you do a 'cvs update -d' to pick up the directories. 

Feel free to reset the cvs flag if you need anything further.
Comment 14 Eric Smith 2011-05-01 03:27:39 EDT
Package Change Request
Package Name: unifdef
New Branches: el6
Owners: brouhaha
Comment 15 Jason Tibbitts 2011-05-05 11:20:11 EDT
Git done (by process-git-requests).
Comment 16 Fedora Update System 2011-05-09 22:24:57 EDT
unifdef-1.171-10.el6 has been submitted as an update for Fedora EPEL 6.
Comment 17 Fedora Update System 2011-05-27 11:12:44 EDT
unifdef-1.171-10.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.