Red Hat Bugzilla – Bug 189937
Review Request: unifdef
Last modified: 2013-01-09 20:23:49 EST
Spec URL: http://david.woodhou.se/unifdef.spec
SRPM URL: http://david.woodhou.se/unifdef-1.171-1.src.rpm
Unifdef is useful for removing ifdefed lines from a file while otherwise
leaving the file alone. Unifdef acts on #ifdef, #ifndef, #else, and #endif
lines, and it knows only enough about C and C++ to know when one of these
is inactive because it is inside a comment, or a single or double quote.
The plan is to use this when building the kernel package, which is why it's
proposed for Core, not Extras.
I'll review this.
- Source should be a URL to the source
- build root should be
- rpmlint is silent.
- builds in mock for i386 / x86_64
Question: How usable is this for kernel building right now? There is some
pushback to not have it in Core until it is actually usable/needed to build the
kernel and that Extras would be a good place to put it until such time as it is
needed. Your thoughts?
The source was obtained from FreeBSD's cvsweb. You can have a CVS pserver URL,
or you can have the name of the tarball I prepared. I prefer the latter.
Fixed buildroot in 1.171-2
I committed a change to the rawhide kernel this morning which uses the new 'make
headers_install' rules to generate kernel headers from the kernel tree. It's
conditional, and turned off right now because it BuildRequires unifdef, which we
don't have yet.
Ah, good point about the source issue. Everything else looks good now, passes
review. Please follow the next steps on the PackageListProcess.
Built in rawhide. Thanks.