Bug 1906076

Series submitted upstream, at:
https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/Q54IABJGUZFM5XIS2U5CMPAYNHMWT2MY/

Bulk update: Move RHEL-AV bugs to RHEL8 with existing RHEL9 clone.

Assigning to virt-maint, as I won't be able to work on this.

For reference, the next steps are the ones mentioned at:
https://marc.info/?l=qemu-devel&m=163658203909207&w=2

Pasting it here:

> We can switch the default, but SeaBIOS maintainers won't include
> the SMBIOS 3.0 code I had submitted[1] until this is supported by
> QEMU.
> 
> After we patch SeaBIOS to support SMBIOS 3.0 and update the
> SeaBIOS binaries in the QEMU tree, we can switch the default in
> Q35 and/or i440fx to SMBIOS 3.0.
> 
> [1] https://www.mail-archive.com/seabios@seabios.org/msg12415.html
>     https://www.mail-archive.com/seabios@seabios.org/msg12438.html

Oh, noticed nothing of that was merged yet.
Kevin suggested to merge 1-18, plus 19 later
after qemu update.  Seems that never happened though ...

Can you push a branch with the latest seabios patches somewhere?
Or git send-email the latest version to me?

On the qemu side: I assume we must keep old machine types at 2.1
and can enable 3.0 for new versions only?  Do we already have a
runtime switch for that?

(In reply to Gerd Hoffmann from comment #5)
> Oh, noticed nothing of that was merged yet.
> Kevin suggested to merge 1-18, plus 19 later
> after qemu update.  Seems that never happened though ...
> 
> Can you push a branch with the latest seabios patches somewhere?
> Or git send-email the latest version to me?

The series I've submitted at https://www.mail-archive.com/seabios@seabios.org/msg12415.html is at:
https://gitlab.com/ehabkost/seabios/-/commits/work/smbios-3.0-v1

An untested rebase (not very recent) is at:
https://gitlab.com/ehabkost/seabios/-/commits/work/smbios-3.0/

> 
> On the qemu side: I assume we must keep old machine types at 2.1
> and can enable 3.0 for new versions only?  Do we already have a
> runtime switch for that?

It is probably safer to keep old machines at 2.1.

I have submitted patches adding a runtime switch ("smbios-entry-point-type" machine property) at:
https://lore.kernel.org/qemu-devel/20211026151100.1691925-1-ehabkost@redhat.com/

upstream status:
 * seabios: patches are merged in master branch, new seabios release should be out rather sooner than later (late january or early february).
 * qemu: someone needs to pick up the qemu patches (see comment 6), the seabios change alone wouldn't fix this.

>  * qemu: someone needs to pick up the qemu patches (see comment 6), the
> seabios change alone wouldn't fix this

Bug for the qemu side of things is 1906077.

Moving this to rhel9, if the fix is going to come as part of the rebase, then we can mark this as TestOnly.
For rhel8, we will create a clone if required.
There are a couple of reasons for this change:
- As Gerd mentioned, "If qemu doesn't switch to smbios-3 by default in rhel-8 we don't need this in rhel-8 either". The work to automatically use SMBIOS 3.0 is to be done as part of BZ#1906076 which is 
  currently targetted for rhel9.
- This will also make things a little more consistent. At the moment, for this support, some bugs are targeted for rhel8 and some are for Rhel9.

According to https://bugzilla.redhat.com/show_bug.cgi?id=1904267#c98, set status to VERIFIED. Thanks.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (seabios bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8051