RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1906076 - seabios: Support SMBIOS 3.0 Entry Point Type
Summary: seabios: Support SMBIOS 3.0 Entry Point Type
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: seabios
Version: 9.0
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: rc
: 9.1
Assignee: Gerd Hoffmann
QA Contact: Xueqiang Wei
URL:
Whiteboard:
Depends On: 2066826
Blocks: 1788991 1906077
TreeView+ depends on / blocked
 
Reported: 2020-12-09 16:06 UTC by Eduardo Habkost
Modified: 2022-11-15 11:00 UTC (History)
12 users (show)

Fixed In Version: seabios-1.16.0-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:12:39 UTC
Type: Feature Request
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2022:8051 0 None None None 2022-11-15 10:13:03 UTC

Description Eduardo Habkost 2020-12-09 16:06:04 UTC
This bug was initially created as a copy of Bug #1904267

I am copying this bug because: 
SMBIOS 3.0 can't be enabled by default in QEMU if we don't support it in Seabios.


A VM with more than ~720 VCPUs can hit the 65535 bytes limit on SMBIOS tables.  edk2, however, supports SMBIOS 3.0 Entry Points.

We need to support SMBIOS 3.0 entry points on Q35, probably through a new command line option.

Comment 1 Eduardo Habkost 2020-12-10 21:56:30 UTC
Series submitted upstream, at:
https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/Q54IABJGUZFM5XIS2U5CMPAYNHMWT2MY/

Comment 3 John Ferlan 2021-09-09 18:42:22 UTC
Bulk update: Move RHEL-AV bugs to RHEL8 with existing RHEL9 clone.

Comment 4 Eduardo Habkost 2021-11-10 22:34:11 UTC
Assigning to virt-maint, as I won't be able to work on this.

For reference, the next steps are the ones mentioned at:
https://marc.info/?l=qemu-devel&m=163658203909207&w=2

Pasting it here:

> We can switch the default, but SeaBIOS maintainers won't include
> the SMBIOS 3.0 code I had submitted[1] until this is supported by
> QEMU.
> 
> After we patch SeaBIOS to support SMBIOS 3.0 and update the
> SeaBIOS binaries in the QEMU tree, we can switch the default in
> Q35 and/or i440fx to SMBIOS 3.0.
> 
> [1] https://www.mail-archive.com/seabios@seabios.org/msg12415.html
>     https://www.mail-archive.com/seabios@seabios.org/msg12438.html

Comment 5 Gerd Hoffmann 2021-11-17 10:13:59 UTC
Oh, noticed nothing of that was merged yet.
Kevin suggested to merge 1-18, plus 19 later
after qemu update.  Seems that never happened though ...

Can you push a branch with the latest seabios patches somewhere?
Or git send-email the latest version to me?

On the qemu side: I assume we must keep old machine types at 2.1
and can enable 3.0 for new versions only?  Do we already have a
runtime switch for that?

Comment 6 Eduardo Habkost 2021-11-17 17:26:11 UTC
(In reply to Gerd Hoffmann from comment #5)
> Oh, noticed nothing of that was merged yet.
> Kevin suggested to merge 1-18, plus 19 later
> after qemu update.  Seems that never happened though ...
> 
> Can you push a branch with the latest seabios patches somewhere?
> Or git send-email the latest version to me?

The series I've submitted at https://www.mail-archive.com/seabios@seabios.org/msg12415.html is at:
https://gitlab.com/ehabkost/seabios/-/commits/work/smbios-3.0-v1

An untested rebase (not very recent) is at:
https://gitlab.com/ehabkost/seabios/-/commits/work/smbios-3.0/

> 
> On the qemu side: I assume we must keep old machine types at 2.1
> and can enable 3.0 for new versions only?  Do we already have a
> runtime switch for that?

It is probably safer to keep old machines at 2.1.

I have submitted patches adding a runtime switch ("smbios-entry-point-type" machine property) at:
https://lore.kernel.org/qemu-devel/20211026151100.1691925-1-ehabkost@redhat.com/

Comment 8 Gerd Hoffmann 2022-01-13 11:12:01 UTC
upstream status:
 * seabios: patches are merged in master branch, new seabios release should be out rather sooner than later (late january or early february).
 * qemu: someone needs to pick up the qemu patches (see comment 6), the seabios change alone wouldn't fix this.

Comment 9 Gerd Hoffmann 2022-01-13 11:14:24 UTC
>  * qemu: someone needs to pick up the qemu patches (see comment 6), the
> seabios change alone wouldn't fix this

Bug for the qemu side of things is 1906077.

Comment 13 Nitesh Narayan Lal 2022-02-03 13:56:02 UTC
Moving this to rhel9, if the fix is going to come as part of the rebase, then we can mark this as TestOnly.
For rhel8, we will create a clone if required.
There are a couple of reasons for this change:
- As Gerd mentioned, "If qemu doesn't switch to smbios-3 by default in rhel-8 we don't need this in rhel-8 either". The work to automatically use SMBIOS 3.0 is to be done as part of BZ#1906076 which is 
  currently targetted for rhel9.
- This will also make things a little more consistent. At the moment, for this support, some bugs are targeted for rhel8 and some are for Rhel9.

Comment 24 Xueqiang Wei 2022-05-06 08:25:24 UTC
According to https://bugzilla.redhat.com/show_bug.cgi?id=1904267#c98, set status to VERIFIED. Thanks.

Comment 26 errata-xmlrpc 2022-11-15 10:12:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (seabios bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8051


Note You need to log in before you can comment on or make changes to this bug.