Bug 191070

Summary:	Review Request: mcstrans
Product:	[Fedora] Fedora	Reporter:	Daniel Walsh <dwalsh>
Component:	Package Review	Assignee:	David Cantrell <dcantrell>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-16 21:52:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	188268

Description Daniel Walsh 2006-05-08 17:54:50 UTC

Spec URL: http://devserv.devel/~dwalsh/SELinux/mcstrans.spec
SRPM URL: http://devserv.devel/~dwalsh/SELinux/mcstrans-0.1.1-1.src.rpm
Description: mcstrans is a replacement for libsetrans.  Basically libselinux will not use a daemon for its translations instead of a shared library.  This will allow us to easily swap in and out different translation daemons.

Comment 1 Jesse Keating 2006-05-09 21:58:45 UTC

Bad:
- buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Source url is 404: http://fedora.redhat.com/projects/mcstrans-0.1.1.tgz
- Build fails on both arches, probably a missing BuildRequires:

mcstransd.c:16:29: error: selinux/setrans.h: No such file or directory



Should be fixed:
- Mix of variables like $RPM_BUILD_ROOT and %{optflags}.  One method should be
consistant throughout

NEEDSWORK

Comment 2 Daniel Walsh 2006-05-09 23:27:22 UTC

Bad:
- buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} 
-n)
> Changed to this.
- Source url is 404: http://fedora.redhat.com/projects/mcstrans-0.1.1.tgz
> Not sure where this link should point.  We are upstream for this so but I am
not sure where we are supposed to put these tarballs.
- Build fails on both arches, probably a missing BuildRequires:

mcstransd.c:16:29: error: selinux/setrans.h: No such file or directory

> Fixed


Should be fixed:
- Mix of variables like $RPM_BUILD_ROOT and %{optflags}.  One method should be
consistant throughout

> Fixed

I updated the tarball and spec file on 
http://devserv.devel/~dwalsh/SELinux

Comment 3 Jesse Keating 2006-05-10 02:58:45 UTC

So it builds now, but rpmlint isn't completely happy.

- Obsoletes libsetrans, but doesn't provide it.  It should provide it for clean
upgrade
- Use of Prereq, this should actually be Requires(pre): followed by a
Requires(post): (sorry I didn't notice this first)

That should be it.  A couple more Warnings but they can be ignored:
W: mcstrans no-url-tag (already talked about, will get that later)
W: mcstrans service-default-enabled /etc/init.d/mcstransd (we want this enabled)
W: mcstrans incoherent-init-script-name mcstransd (um, whatever)

Comment 4 Daniel Walsh 2006-05-10 17:59:26 UTC

Updated again.

We need this in tonight, since libselinux requires it in rawhide now...

Comment 5 Jesse Keating 2006-05-11 02:35:05 UTC

Builds now, just the ignorable warnings.  Approving.  (and since you're asleep
probably, building it for rawhide.)

Comment 6 Jesse Keating 2006-05-16 21:52:08 UTC

Package was released to rawhide.